Fixing port logic family unit tests to skip on Linux #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YeimiinCheah-NI
requested review from
bkeryan,
maxxboehme and
zhindes
as code owners
zhindes
approved these changes
Mar 3, 2025
bkeryan
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contribution adheres to CONTRIBUTING.md.
I've updated CHANGELOG.md if applicable.
- [ ] I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
This pull-request is to fix the port logic family unit tests on the test_physical_channel_properties.py. As of 25.3, the mioDAQ only support Windows and both get and set port logic family tests are trying to create a simulated device on Linux which causes the test to failed. Hence, I'm marking both of them to skip when it is not Windows.
Why should this Pull Request be merged?
To fix BUG 2955106
What testing has been done?
Successfully build locally:
Used the CompTest-u2004 to perform the test on Ubuntu and the tests are passing now:
Before:
After: