Pick up new error code metadata for mioDAQ configurable digital voltage feature #659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge feature Signed-off-by: Siu Fong Tan <[email protected]>
SiuFong-NI
requested review from
bkeryan,
maxxboehme and
zhindes
as code owners
zhindes
approved these changes
Nov 14, 2024
|
@charitylxy probably need your help again to merge this (on behalf of me) as I do not have write access. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Pickup new DAQmx error code metadata in https://github.com/ni/grpc-device-scrapigen/pull/255.
Why should this Pull Request be merged?
This is needed by mioDAQ configurable digital voltage feature to report better error in Python.
What testing has been done?
Ran poetry run pytest and result looks good.
