nidaqmx: Fix installation with Python 3.13 #645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhindes
approved these changes
Oct 16, 2024
… not`, for instance checks use `isinstance()`
bkeryan
commented
Oct 16, 2024
bkeryan
added a commit
that referenced
this pull request
Oct 17, 2024
* tests: Fix OverflowError: Python integer 36767 out of bounds for int16 * tests: Skip more examples * nidaqmx: Update dependency versions for Python 3.13 support * Update poetry.lock * GitHub: Enable unit tests on Python 3.13 * tests: Reformat with black * tests: Fix E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()` * nidaqmx: Allow newer types-protobuf * nidaqmx: Update poetry.lock (cherry picked from commit ee791a3)
1 task
bkeryan
added a commit
that referenced
this pull request
Oct 17, 2024
* nidaqmx: Fix installation with Python 3.13 (#645) * tests: Fix OverflowError: Python integer 36767 out of bounds for int16 * tests: Skip more examples * nidaqmx: Update dependency versions for Python 3.13 support * Update poetry.lock * GitHub: Enable unit tests on Python 3.13 * tests: Reformat with black * tests: Fix E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()` * nidaqmx: Allow newer types-protobuf * nidaqmx: Update poetry.lock (cherry picked from commit ee791a3) * tox: Enable Python 3.13 (#646) (cherry picked from commit dab722c) * nidaqmx: Add Python 3.13 trove classifier and update changelog (#649) * nidaqmx: Add Python 3.13 trove classifier * nidaqmx: Update changelog (cherry picked from commit ba8a962)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Update the dependency versions in
pyproject.tomlto be compatible with Python 3.13. For per-Python version constraints, make sure the last version is^3.13so that it will also cover 3.14, etc.Loosen
protobufversion constraint to allowprotobuf5.x becausegrpcio-tools1.67 requiresprotobuf5.x.Enable running unit tests with Python 3.13 for the PR/CI workflows. I didn't do this for system tests yet because we need to update our self-hosted runner image.
Fix a couple of system test failures:
test_in_stream.pyhad incorrect constants for +/-full-scale int16 values, which causes an overflow error with the updatednumpy.Why should this Pull Request be merged?
Partially fixes #644
What testing has been done?
poetry run pytest -vThe failures are expected, I have a really old X Series board that has never been recalibrated.