Use ascii encoding when locale is not set #643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhindes
changed the title
bkeryan
approved these changes
Oct 10, 2024
WayneDroid
pushed a commit
that referenced
this pull request
Nov 5, 2024
* return ascii encoding when locale is not set
1 task
WayneDroid
added a commit
that referenced
this pull request
Nov 6, 2024
* return ascii encoding when locale is not set Co-authored-by: Zach Hindes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Fall back to "ascii" encoding if the locale isn't set (and we aren't using utf8 APIs)
Why should this Pull Request be merged?
Closes #641
What testing has been done?