Add the digital waveform type to waveform.proto. #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Johansen <[email protected]>
bkeryan
reviewed
Jul 17, 2025
bkeryan
reviewed
Jul 17, 2025
bkeryan
reviewed
Jul 17, 2025
Signed-off-by: Michael Johansen <[email protected]>
bkeryan
approved these changes
Jul 17, 2025
csjall
approved these changes
Jul 18, 2025
|
Update PR description to match revised implementation. |
Signed-off-by: Michael Johansen <[email protected]>
nick-beer
approved these changes
Jul 22, 2025
|
Bypassing owners: sufficient review, @jasonmreding is OOO Cc: @ccifra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
DigitalWaveformto waveform.proto.bytesalong withsignal_countthat can be used to unflatten the array.Why should this Pull Request be merged?
Implements AB#3200675
What testing has been done?
None