-
Notifications
You must be signed in to change notification settings - Fork 4
Update data_store and metadata_store protos to match ATML naming schema #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks good to me. I think that we should address a couple of the comments that Reding posted. I've tried to be explicit about what I think we should change, and what I think we can leave.
I don't think we're that far off, but I would like to take a quick look at the next update before approving. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for next update before approving. I don't see anything overly concerning here though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few other inconsistencies to address.
What does this Pull Request accomplish?
Applies grpc best practices and ATML-style naming to the data store service and metadata store service entities.
Why should this Pull Request be merged?
Clarifies proto file messages, methods, and fields.
What testing has been done?
N/A