Skip to content

Conversation

papowerNI
Copy link
Contributor

What does this Pull Request accomplish?

Applies grpc best practices and ATML-style naming to the data store service and metadata store service entities.

Why should this Pull Request be merged?

Clarifies proto file messages, methods, and fields.

What testing has been done?

N/A

@papowerNI papowerNI changed the title Update data_store and metadata_store protos to match ATML naming scheme Update data_store and metadata_store protos to match ATML naming schema Sep 4, 2025
Copy link
Collaborator

@nick-beer nick-beer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks good to me. I think that we should address a couple of the comments that Reding posted. I've tried to be explicit about what I think we should change, and what I think we can leave.

@jasonmreding
Copy link
Collaborator

Overall, this looks good to me. I think that we should address a couple of the comments that Reding posted. I've tried to be explicit about what I think we should change, and what I think we can leave.

I don't think we're that far off, but I would like to take a quick look at the next update before approving.

Copy link
Collaborator

@jasonmreding jasonmreding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for next update before approving. I don't see anything overly concerning here though.

Copy link
Collaborator

@jasonmreding jasonmreding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few other inconsistencies to address.

@papowerNI papowerNI merged commit 721ca34 into main Sep 11, 2025
1 check passed
@papowerNI papowerNI deleted the users/papower/update-data-store-protos branch September 11, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants