Revert "ptp: remove ptp->n_vclocks check logic in ptp_vclock_in_use()" #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2591195 as it causes clock_adjtime to fail with "ptp: physical clock is free running" in kernel log. Signed-off-by: Chaitanya Vadrevu <[email protected]>
gratian
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 2591195 as it causes clock_adjtime to fail with "ptp: physical clock is free running" in kernel log.
WI: AB#3184608
Testing
./testptp -f 0succeeds on a cRIO-9049 (testptp from tools/testing/selftests/ptp/testptp.c). It fails without this revert.lsof /dev/ptp0shows multiple processes have opened/dev/ptp0.Note
The problematic commit is not yet present in
nilrt/master/6.12. I've added notes in kernel upgrade work items in this cycle AB#3125763 and AB#3125752 to address this bug if the commit ends up in 6.12 eventually.