Rectify Bluefin NAND on-die ECC support #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bdc6c24. Signed-off-by: HatsyRei <[email protected]>
This reverts commit 0bd6d36. Signed-off-by: HatsyRei <[email protected]>
HatsyRei
force-pushed
the
nilrt/master/6.6
branch
3 times, most recently
from
cfd373e to
b13fd68
Compare
Add `enable_subpage_read` and `enable_subpage_write` load-time options to toggle subpage read/write operations on pl353 chips. Both options are enabled by default, and may be toggled in the boot loader. Signed-off-by: Haris Okanovic <[email protected]> Acked-by: Gratian Crisan <[email protected]> Acked-by: Jeff Westfahl <[email protected]> Natinst-CAR-ID: 599280 Natinst-ReviewBoard-ID: 151758 (cherry picked from commit 311a5711cfdbfa20e3f4ec2dbd429f96b9f76c2f) (cherry picked from commit f261b4b) Signed-off-by: HatsyRei <[email protected]>
Existing devices which utilize Micron NAND may contain partitions formatted with subpages. Support this use case by implementing hooks for subpage read and write in Micron NAND driver. Signed-off-by: HatsyRei <[email protected]>
HatsyRei
force-pushed
the
nilrt/master/6.6
branch
from
b13fd68 to
2fa8029
Compare
chaitu236
approved these changes
Apr 22, 2025
gratian
approved these changes
Apr 22, 2025
|
@HatsyRei Can you create a PR with these changes against our 'kernel-next' branch too: Normally I would just cherry pick them but this is a bit non-trivial due to the reverts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WI: AB#3076957
Bluefin utilizes the Micron MT29F2G08ABBEAH4 NAND flash via the onboard PL353 NAND controller. In 4.1, on-die ECC operations along with raw NAND read/write hooks were implemented in the pl353_nand driver. Following 10d4e75, Micron NAND specific logic has been moved into nand_micron.c.
This PR rectifies previous on-die ECC and NAND subpage read/write implementations by implementing NAND on-die ECC subpage read/write support in nand_micron.c instead of pl35x-nand-controller.c.
Testing: Deployed changes onto cDAQ-9189. Previously observed bitflips no longer reproducible after on-die ECC is enabled correctly.