mmc: Add quirk to disable DDR50 tuning#213
mmc: Add quirk to disable DDR50 tuning#213erickshepherdNI wants to merge 3 commits intoni:nilrt/master/6.6from
Conversation
chaitu236
left a comment
There was a problem hiding this comment.
Changes lgtm. But please add WI# to PR description and rebase to latest nilrt/master/6.6.
Btw, did you end up testing on other controllers? What were the findings?
cbcc07b to
a7f92a6
Compare
I updated the PR description and rebased the changes. as far as other testing, I was not able to reproduce the issue on a 9034 with the same Swissbit card. I'd be curious to test on more hardware configurations but this change should be ok since the card doesn't support tuning anyway. |
I see. Did we get the info about it's tuning support from it's manual/manufacturer? |
I dug up the exact card model and spec sheet when I started working on this and confirmed that the card was built to the 3.0 SD spec that does not support DDR50 tuning. I can find the documentation again and attach it to the work item. It would probably be good to have for future reference. |
gratian
left a comment
There was a problem hiding this comment.
Looks good. Just a nitpick on the comment being too general to be useful.
Also looks like check-patch flagged an indentation warning (see the 'Checks' tab in the PR).
91b2a63 to
a36e3c7
Compare
a36e3c7 to
da6fba8
Compare
This reverts commit 13dc7b7. Signed-off-by: Erick Shepherd <erick.shepherd@ni.com>
This reverts commit ffa0743. Signed-off-by: Erick Shepherd <erick.shepherd@ni.com>
Adds the MMC_QUIRK_NO_UHS_DDR50_TUNING quirk and updates mmc_execute_tuning() to return 0 if that quirk is set. This fixes an issue on certain Swissbit SD cards that do not support DDR50 tuning where tuning requests caused I/O errors to be thrown. Signed-off-by: Erick Shepherd <erick.shepherd@ni.com>
da6fba8 to
d6a08e8
Compare
|
@erickshepherdNI can this be closed? |
Adds the MMC_QUIRK_NO_UHS_DDR50_TUNING quirk and updates
mmc_execute_tuning() to return 0 if that quirk is set. This fixes an
issue on certain Swissbit SD cards that do not support DDR50 tuning
where tuning requests caused I/O errors to be thrown.
WI#2805437
Testing
Built the kernel and confirmed that the SD card attempts to tune but is stopped by the new change. No I/O errors were thrown.