Iteration 4 of CI Hardening #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
svelderrainruiz
commented
Aug 7, 2025
svelderrainruiz
commented
## Summary - document checkout step using `actions/checkout@v4` - update CI workflow to use `actions/checkout@v4` with full history ## Testing - `pytest` ------ https://chatgpt.com/codex/tasks/task_e_6894dfb82cf88329875ab2db3c0efd2f
## Summary - clarify that workflow triggers for issue branches but jobs require passing issue-status gate - note that runs failing the gate appear in GitHub Actions and skip later jobs ## Testing - `npm test` (fails: could not read package.json) - `pytest` (no tests ran) ------ https://chatgpt.com/codex/tasks/task_e_6894e331dcc08329b99e78a664aa2841
## Summary - clarify that `issue-status` job checks the issue's project **Status** field and requires `In Progress` - note that contributors must add their issue to a project with that status ## Testing - `npm test` *(fails: Could not read package.json)* ------ https://chatgpt.com/codex/tasks/task_e_6894e50659a48329a437ea98874db831
## Summary - note unit tests run in ci-composite.yml test job instead of separate workflow - update example developer workflow to use composite CI tests ## Testing - `pwsh .github/actions/run-unit-tests/RunUnitTests.ps1 -MinimumSupportedLVVersion 2021 -SupportedBitness 64` *(fails: command not found)* - `apt-get install -y powershell` *(fails: Unable to locate package powershell)* ------ https://chatgpt.com/codex/tasks/task_e_6894e7257eb4832993e9281f65bc1665
## Summary - clarify that merging does not create a release automatically - note that the ci-composite workflow only uploads the VI Package artifact ## Testing - `pytest` ------ https://chatgpt.com/codex/tasks/task_e_6894e9d8cac883299e54158ff86b2d69
## Summary - update apply-vipc action README to use LabVIEW 2021 in sample inputs - note that CI installs dependencies for LabVIEW 2021 (32/64-bit) and 2023 (64-bit) ## Testing - `npm test` *(fails: ENOENT no such file or directory, open 'package.json')* ------ https://chatgpt.com/codex/tasks/task_e_6894eb5a7b908329810236b651bc9ce6
## Summary - clarify missing-in-project-check workflow dependencies - update examples to LabVIEW 2021 and show 32/64-bit matrix - refresh local testing snippet ## Testing - `npm test` *(fails: Could not read package.json)* ------ https://chatgpt.com/codex/tasks/task_e_6894ec906c708329bcf18f0b28757660
## Summary
- update AuthorName example in automated setup docs to use `${{
github.event.repository.name }}`
## Testing
- `npm test` *(fails: could not find package.json)*
- `python -m pytest`
------
https://chatgpt.com/codex/tasks/task_e_6894ef3b36688329a652f51f2b0f2385
## Summary - document build-ppl as a matrix job for 32- and 64-bit builds - show build-vi-package as a separate job that packages only the 64-bit output - note why the packaging job runs outside the bitness matrix ## Testing - `npm test` *(fails: Could not read package.json)* ------ https://chatgpt.com/codex/tasks/task_e_6894f040bdd083299b1f8a9e580a59db
## Summary - clarify that the default CI matrix runs only on `self-hosted-windows-lv` - mention `self-hosted-linux-lv` is only included for future expansion ## Testing - `npm test` *(fails: Could not read package.json)* ------ https://chatgpt.com/codex/tasks/task_e_6894f226a1908329a4adb2987677d67e
## Summary - skip CI jobs when a pull request or branch carries a `NoCI` label - document how the `NoCI` label gates CI runs across guides and troubleshooting ## Testing - `markdownlint docs/ci/actions/maintainers-guide.md docs/ci/actions/troubleshooting-experiments.md docs/ci-workflows.md` (fails: MD013 line-length and other warnings) - `./actionlint .github/workflows/ci-composite.yml` (fails: unknown runner label) - `npm test` (fails: could not read package.json) ------ https://chatgpt.com/codex/tasks/task_e_6894f3b411b48329a13f6c9a0b3876d3
## Summary - merge split gate sentence for clarity in build-vi-package docs ## Testing - `npm test` *(fails: Could not read package.json)* ------ https://chatgpt.com/codex/tasks/task_e_6894f7fbf51c8329b1cada03b5000c9e
## Summary - clarify that runner dependencies VIPC must be applied manually on new runners - reference the `apply-deps` conditional in `ci-composite.yml` ## Testing - `npm test` *(fails: package.json missing)* ------ https://chatgpt.com/codex/tasks/task_e_689502d003b48329b752514f0a0c4240
## Summary - avoid line-number drift in automated setup by linking to ci-composite workflow's Upload VI Package step without anchors ## Testing - `pytest` ------ https://chatgpt.com/codex/tasks/task_e_689503da7b008329b6b37f4ac90d2858
## Summary - clarify how the `issue-status` gate evaluates pull request branches before the `version` and `build-ppl` jobs ## Testing - `pytest` (no tests ran) ------ https://chatgpt.com/codex/tasks/task_e_6895059917f88329be6cc54c7031c94f
## Summary - note unlabeled pull requests default to a patch version bump in the CI workflow - reference compute-version action to highlight the patch default ## Testing - `npm test` *(fails: Could not read package.json)* ------ https://chatgpt.com/codex/tasks/task_e_689508d4df9083299c2f7b0f136be852
## Summary - explain manual `workflow_dispatch` runs still need branch name `issue-<number>` and linked issue In Progress ## Testing - `pytest` ------ https://chatgpt.com/codex/tasks/task_e_68950a6543208329b46ff1aecf04d46a
## Summary - document all required CI jobs that block merges - note that issue-status gating can skip downstream jobs ## Testing - `python -m pytest` ------ https://chatgpt.com/codex/tasks/task_e_68950bae4d10832993914e95b01444f8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.