Iteration 1 of CI Hardening #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
svelderrainruiz
commented
Aug 7, 2025
svelderrainruiz
commented
## Summary - document the correct `self-hosted-windows-lv`/`self-hosted-linux-lv` runner labels - clarify that CI builds artifacts but does not tag or create releases - refresh example GitHub Action versions and note issue-status gating ## Testing - `npm test` *(fails: package.json missing)* - `pytest` ------ https://chatgpt.com/codex/tasks/task_e_6893ecd48e3883298911bf2c9ffdddc3
## Summary - rename `build-vip` job to `build-vi-package` - strip GPG references from CI docs - fix troubleshooting numbering after removing GPG entry ## Testing - `npm test` *(fails: Could not read package.json)* ------ https://chatgpt.com/codex/tasks/task_e_6893f013db2c83299e470bc57c5ad02a
## Summary - reference the CI Pipeline (Composite) workflow and its Build VI Package job in CONTRIBUTING - clarify where to find bump-type logs in the version job - rename Build VI Package workflow references across CI docs ## Testing - `pytest` ------ https://chatgpt.com/codex/tasks/task_e_6893f4249b48832988ebe047dd7746a0
## Summary - document missing `compute-version` and `generate-release-notes` composite actions - replace fragile line-number link to `issue-status` job with stable reference - clarify that `build-vi-package` triggers come from the workflow and update QA example to use `run-unit-tests` ## Testing - `npm test` *(fails: Could not read package.json)* ------ https://chatgpt.com/codex/tasks/task_e_6893f776c70c8329883117a4ac0c4bb2
## Summary - clarify that unit tests run in a dedicated `test` job and versioning happens in the `version` job - remove misleading Linux runner label instructions - note that `compute-version` drives versioning in CI pipeline docs ## Testing - `npx -y markdownlint-cli --config /tmp/md-config.json docs/ci/actions/runner-setup-guide.md docs/powershell-cli-github-action-instructions.md` ------ https://chatgpt.com/codex/tasks/task_e_6893fa6b5814832980290ede73968219
## Summary - remove unused `unit-tests` action entry - document required inputs for build-vi-package action - fix checkout version and quickstart numbering ## Testing - `npm test` *(fails: Could not read package.json)* - `pytest` ------ https://chatgpt.com/codex/tasks/task_e_6893fdc61ba48329b9e184c12829145c
## Summary - clarify build-number computation in runner setup guide - note issue-status gating for build-vi-package action ## Testing - `pytest` ------ https://chatgpt.com/codex/tasks/task_e_68940152e9c88329abf02026a4d66881
## Summary - clarify that the `apply-deps` CI job runs only when `.vipc` files change - document manual VIPC application on new runners and note Linux runner label usage ## Testing - `pytest` ------ https://chatgpt.com/codex/tasks/task_e_689404fe9de88329a8f9db75221cc223
## Summary - clarify CI Quickstart step on which branches trigger the workflow - explain gating that limits full CI runs to `issue-*` branches linked to In Progress issues ## Testing - `npx markdownlint-cli docs/ci-workflows.md --disable MD013 MD032` ------ https://chatgpt.com/codex/tasks/task_e_68940a6313e48329b6a008fc8aacb349
## Summary - Document that CI's build-vi-package job produces only a 64-bit .vip - Reference `supported_bitness: 64` in the workflow config ## Testing - `pytest` ------ https://chatgpt.com/codex/tasks/task_e_68940b7800d48329addce82ffb8fd9ce
## Summary - document default `Company Name` and `Author Name` sources in CI - describe how to override branding via `ci-composite.yml` ## Testing - `pytest` ------ https://chatgpt.com/codex/tasks/task_e_68940c6f1ebc8329b0ebb58da5d13da7
## Summary - drop outdated `unit-tests` composite action - document unit test script usage in `RunUnitTests.ps1` ## Testing - `python -m py_compile scripts/update_readme_hours.py` ------ https://chatgpt.com/codex/tasks/task_e_68940da3d1b0832986f4c2a2e92ce2c2
## Summary - use `actions/checkout@v4` in the "Check Out & Full Clone" step of the build-vi-package docs ## Testing - `npm test` *(fails: Could not read package.json)* - `python -m pytest` *(no tests ran)* ------ https://chatgpt.com/codex/tasks/task_e_68940f2d423083298c5a830a69e2361e
## Summary - list release branch patterns in quickstart and separate feature/hotfix categories - document that CI jobs require branches prefixed with `issue-` ## Testing - `npx [email protected] docs/ci-workflows.md docs/powershell-cli-github-action-instructions.md docs/ci/actions/build-vi-package.md` *(fails: line-length and style warnings)* ------ https://chatgpt.com/codex/tasks/task_e_689410fa76e483299b93c36e7a5d5556
## Summary - check pull request head branch when verifying issue status - document CI trigger conditions and branch requirements ## Testing - `pytest` ------ https://chatgpt.com/codex/tasks/task_e_6894158017388329b6abf2d7c02364fc
## Summary - update release branch example to use `release-rc/1.2` - note alpha/beta/rc branch naming scheme per `ci-composite.yml` ## Testing - `pytest` *(no tests found)* ------ https://chatgpt.com/codex/tasks/task_e_689423496d9c83298cef7d6f88be2e2d
## Summary - allow `issue-*` branches to trigger CI - detect issue numbers in branches like `feature/issue-123` - document how branch names interact with CI gate ## Testing - `npm test` *(fails: ENOENT: no such file or directory, open '/workspace/labview-icon-editor/package.json')* ------ https://chatgpt.com/codex/tasks/task_e_6894253c7c9c8329b290a6dd17e1a932
## Summary - highlight that ci-composite.yml only executes downstream jobs when `issue-status` passes - mention branch naming requirement (`issue-<number>`) to avoid skipped CI on release branches ## Testing - `pytest` ------ https://chatgpt.com/codex/tasks/task_e_689426923f1c8329b8b78efa0d4a22e4
## Summary - clarify that the `version` job runs the `compute-version` action ## Testing - `python -m pytest` ------ https://chatgpt.com/codex/tasks/task_e_689427d1bcb4832988a39d4ee32b7563
## Summary - detail required version metadata inputs for `build-lvlibp` - document version and release inputs for `build-vi-package` ## Testing - `pytest` ------ https://chatgpt.com/codex/tasks/task_e_689428eac5108329ba67f443f026080b
## Summary - update CI doc to reference LabVIEW 2023 - adjust sample steps to use `minimum_supported_lv_version: 2023` ## Testing - `pytest` ------ https://chatgpt.com/codex/tasks/task_e_689429d492ac8329bc5ebaa03452caba
## Summary - fix link to `issue-status` job in multichannel release workflow docs - avoid brittle line anchors and mention current job range ## Testing - `pytest` ------ https://chatgpt.com/codex/tasks/task_e_68942c7d3c1c8329ba58146bfaa3d833
## Summary - document `issue-*` branch trigger in multichannel release workflow guide - add `issue-*` to CI pipeline instructions to match composite workflow ## Testing - `npm test` *(fails: ENOENT: no such file or directory, open package.json)* ------ https://chatgpt.com/codex/tasks/task_e_68942d7c1a648329a2d4ccb6cca4a4c4
## Summary - reference `actions/checkout@v4` in `build-vi-package` documentation to match workflow pin ## Testing - `npm test` *(fails: could not read package.json)* ------ https://chatgpt.com/codex/tasks/task_e_68942e638e848329b0b15071876b784a
## Summary - document that CI gating runs for any branch containing `issue-<number>` to match the workflow regex ## Testing - `npm test` *(fails: Could not read package.json)* ------ https://chatgpt.com/codex/tasks/task_e_689430a041d8832996f57ccd2f3770af
## Summary - document `build-lvlibp` usage with matrix bitness, LV 2021 minimum, and `github.sha` - note that packed libraries build for 32- and 64-bit separately and package step uses only 64-bit LabVIEW 2023 - align example with `.github/workflows/ci-composite.yml` and uppercase version outputs ## Testing - `npm test` (fails: missing package.json) - `pytest` ------ https://chatgpt.com/codex/tasks/task_e_689431d6b1ec8329ba69f79cbc947e69
## Summary - highlight that `workflow_dispatch` allows running the main CI workflow manually ## Testing - `python -m pytest` ------ https://chatgpt.com/codex/tasks/task_e_68943346744483299dbaac611aaf24cb
## Summary - mark `build` composite action as deprecated - note that `ci-composite.yml` workflow uses `build-lvlibp` and `build-vi-package` for builds ## Testing - `python -m pytest` ------ https://chatgpt.com/codex/tasks/task_e_68943476c1ec8329bebe4bcdab154a34
## Summary - clarify Issue-Status Gate section to reference `issue-status` job instead of line numbers ## Testing - `npm test` *(fails: could not read package.json)* ------ https://chatgpt.com/codex/tasks/task_e_6894359d12308329815739b128f38201
## Summary - align build-vi-package docs with action implementation by using `actions/checkout@v3` ## Testing - `npm test` *(fails: Could not read package.json: ENOENT: no such file or directory)* ------ https://chatgpt.com/codex/tasks/task_e_6894368c2e28832980b2cf62ad88ac81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.