Skip to content

Conversation

svelderrainruiz
Copy link
Collaborator

GitHub Issue for the Pull Request

Link to the relevant GitHub issue

GitHub Discussions Related to this Pull Request

List any GitHub discussion links related to this PR

Checklists

Completing these checklists ensures that your PR meets our build server requirements on the first attempt. If you're unable to complete any of the following checks, please submit your PR as a draft to the best of your ability. We will provide any clarification you may need after posting it.

  • I do not require assistance from NI to complete any of the following checks.
  • The changes in this PR are based on the appropriate NI-repo feature branch
  • I am submitting the changes in this PR to the appropriate NI-repo feature branch
  • I built a VI Package using the Powershell build tool.
  • I installed the VI Package produced by the Powershell build tool and tested my change.
  • I tested my changes after installing the VI package.
  • NI has my contributor license agreement.

Summary of Changes

Provide a concise overview of what is being added, modified, or fixed in this pull request. Make an emphasis on whas was not captured on the GitHub issue, or discussion associated with this PR.

Reason for Change

Explain the problem or need addressed by this pull request, including any relevant background information.

Visual Aids

Include any visual aids that would help the reviewer gain additional context.

Additional Information

Include any further details that may assist the reviewer in understanding the context of this PR.

Testing

This section describes the automated and manual tests performed for this bugfix/feature.

Manual Tests

Describe any manual tests conducted.

svelderrainruiz and others added 30 commits February 8, 2025 14:32
Moving information from the readme to the wiki
* Squashed commit of the following:

commit df25205
Author: Sergio Velderrain <[email protected]>
Date:   Mon Feb 17 11:32:48 2025 -0800

    Adding last details

commit 8c33476
Author: Sergio Velderrain <[email protected]>
Date:   Mon Feb 17 11:26:14 2025 -0800

    adding

commit aab5ec7
Author: Sergio Velderrain <[email protected]>
Date:   Mon Feb 17 10:47:06 2025 -0800

    commiting

commit 1a8e6d0
Author: Sergio Velderrain <[email protected]>
Date:   Mon Feb 17 09:10:52 2025 -0800

    a

* Updating contributing.md

* Update CONTRIBUTING.md

Adding changes from review

---------

Co-authored-by: Sergio Velderrain <[email protected]>
* Create pull_request_template.md

* Create bug_fix.md

* Create feature_request.md

* Create infrastructure_change.md

* Create documentation.md

* Update infrastructure_change.md

* Update feature_request.md

* Update bug_fix.md

* Update feature_request.md

* Update feature_request.md

* Adding changes from review

* Adding empty pull request template

---------

Co-authored-by: Sergio Velderrain <[email protected]>
…of Caraya, still need to update Missing VIs
* Removed the option of removing the layers tab from the runtime menu and the ini file
Removed the layers tab visible option from all settings clusters and classes

* Removed ShowLayersPalette.vi from the project
Saved Settings.ctl in 2021

---------

Co-authored-by: Tim Robinson <[email protected]>
Corrected capitalization typo
Updated lines 12 and 13 per comment by j-medland
* Removed unused dependencies and updated the VIPC used by all

* User no longer needs to set the system on development mode to use the build script

* User can install the VI package immediately after the Powershell script builds it, without having to revert development mode. 

---------

Co-authored-by: Sergio Velderrain <[email protected]>
Adding minimum set of instructions on how to use the build tools
Powershell scripts and github action have been integrated and can now run unit tests, built ppl, and the VI package. This gh action will post the vi package on the artifacts section of the gh action
Had the wrong command on the powershell editing guide

Signed-off-by: sergiov-ni <[email protected]>
* Feature/25 valid library icon check disable juan (#130)

* Implemented reading the token NI.LV.TextIcon.SkipLibraryIconValidityCheck from the LabVIEW INI file. If the token is present and True, the Good Library Icon output is always True. If an error occurs it is merged to the current error output.

* Revert "Implemented reading the token NI.LV.TextIcon.SkipLibraryIconValidityCheck from the LabVIEW INI file. If the token is present and True, the Good Library Icon output is always True. If an error occurs it is merged to the current error output."

This reverts commit 361be22.

* Implemented reading the token NI.LV.TextIcon.SkipLibraryIconValidityCheck from the LabVIEW INI file using LabVIEW\resource\dialog\lvconfig.llb\LV Config Read Boolean.vi. If the token is present and True, the Good Library Icon output is always True. If an error occurs it is merged to the current error output.

---------

Co-authored-by: Juan Jose Hasbun Wood <[email protected]>
svelderrainruiz and others added 27 commits April 20, 2025 21:08
Fixed a bug when uninstalling VI Package
Made icon editor green

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
this is kind of green
…onnect-make-the-background-editor-black

Made front panel black
…he-background-editor-black

Feature/195 feature ni connect make the background editor black
…t-make-the-background-editor-black"

This reverts commit c04910e, reversing
changes made to c2debb9.
Signed-off-by: sergiov-ni <[email protected]>
@svelderrainruiz svelderrainruiz merged commit 2987099 into main Apr 24, 2025
12 of 15 checks passed
@svelderrainruiz svelderrainruiz deleted the release-rc/0.2 branch April 24, 2025 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants