Skip to content

Conversation

svelderrainruiz
Copy link
Collaborator

@svelderrainruiz svelderrainruiz commented Mar 8, 2025

  • Implemented reading the token NI.LV.TextIcon.SkipLibraryIconValidityCheck from the LabVIEW INI file using LabVIEW\resource\dialog\lvconfig.llb\LV Config Read Boolean.vi. If the token is present and True, the Good Library Icon output is always True. If an error occurs it is merged to the current error output.

HasbunWoodEngineering and others added 2 commits March 4, 2025 09:34
* Deleting PR template so that the templates on the folder can be used.

* Implemented reading the token NI.LV.TextIcon.SkipLibraryIconValidityCheck from the LabVIEW INI file. If the token is present and True, the Good Library Icon output is always True. If an error occurs it is merged to the current error output.

* Revert "Implemented reading the token NI.LV.TextIcon.SkipLibraryIconValidityCheck from the LabVIEW INI file. If the token is present and True, the Good Library Icon output is always True. If an error occurs it is merged to the current error output."

This reverts commit 361be22.

* Implemented reading the token NI.LV.TextIcon.SkipLibraryIconValidityCheck from the LabVIEW INI file using LabVIEW\resource\dialog\lvconfig.llb\LV Config Read Boolean.vi. If the token is present and True, the Good Library Icon output is always True. If an error occurs it is merged to the current error output.

---------
@svelderrainruiz svelderrainruiz marked this pull request as ready for review March 8, 2025 04:01
@svelderrainruiz svelderrainruiz added the Type: Enhancement New feature or request label Mar 8, 2025
@svelderrainruiz svelderrainruiz disabled auto-merge March 8, 2025 04:12
@svelderrainruiz svelderrainruiz enabled auto-merge (squash) March 8, 2025 04:14
@svelderrainruiz svelderrainruiz disabled auto-merge March 8, 2025 04:31
@svelderrainruiz svelderrainruiz marked this pull request as draft March 8, 2025 04:32
@svelderrainruiz svelderrainruiz marked this pull request as ready for review March 8, 2025 04:33
@svelderrainruiz svelderrainruiz merged commit 30580ff into develop Mar 8, 2025
4 checks passed
@svelderrainruiz svelderrainruiz deleted the feature/25-fix branch March 18, 2025 14:40
svelderrainruiz added a commit that referenced this pull request Aug 7, 2025
## Summary
- merge split gate sentence for clarity in build-vi-package docs

## Testing
- `npm test` *(fails: Could not read package.json)*

------
https://chatgpt.com/codex/tasks/task_e_6894f7fbf51c8329b1cada03b5000c9e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor Type: Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add INI token to ignore 'valid library icon' check when creating Text Icon

2 participants