-
Notifications
You must be signed in to change notification settings - Fork 25
90 create a vipc that has fewer dependencies #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
90 create a vipc that has fewer dependencies #132
Conversation
@svelderrainruiz - Can you expand on why you have ended up with these as dependencies for the runner?
|
I am actively working on the unit tests that are in the project. I plan to have a PR submitted later this week. |
Thank you for the update. Once you are done, ill make another Github Issue for the block of work to update my powershell process to use LUnit instead of Caraya. By then we will have a benchmark using Caraya, and i will be able to produce one for LUnit to discuss the improvements on first time setup time. This should be interesting. |
|
Regarding @crossrulz point 2 I would argue we should have the documentation in the code repo as a text file. It is something that changes with the code and will need to be managed through PRs so having it in the code makes more sense to me. |
Yes, but that will be on a separate PR, this PR is just to slim down the dependencies for the runner. This new set of dependencies took me 50 minutes to install on a a clean system with nothing but LabVIEW 32 and 64 bits installed.
Understood, ill produce that. |
@j-medland you may have a system that had some of the components from the VIPC already installed, see below a screenshot of a system that had no dependencies installed. ![]() |
I would probably do a markdown so you can have some formatting. |
Developers use this new VIPC, it now takes 5 minutes to install. Runner also uses this same VIPC, although i will separate into a separate VIPC if i ever need to expand to more dependencies on the runner.
The dependencies that are being added are there because of the VI packages that my CI tooling uses. Non of these dependencies are being added to the icon editor itself, only to the VIs used by my powershell scripts. I will add a section on the wiki (automation) that mentions dependencies used for CI/CD tooling. I added a video on how i use the scripts from this PR as well with the fewer dependencies this PR has, and it takes no longer than 10 minutes to install dependencies for both 32 and 64 bit labview. https://github.com/ni/labview-icon-editor/wiki/Contributors-Guide#contributionprocess |
A change to the readme.md is the right spot. I'd say we approve this PR, since it is specific for a VIPC with fewer dependencies. |
## Summary - revise troubleshooting and FAQ entries about releases - note that composite pipeline only uploads artifacts and releases must be created separately ## Testing - `pytest` ------ https://chatgpt.com/codex/tasks/task_e_6894c30de9088329b22e26e94cdefdc4
No description provided.