Skip to content

121 update contributingmd #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 18, 2025
Merged

121 update contributingmd #122

merged 3 commits into from
Feb 18, 2025

Conversation

svelderrainruiz
Copy link
Collaborator

Updating contributing.md
had deprecated information and links to old information

@svelderrainruiz
Squashed commit of the following:
77317f6 
commit df25205
Author: Sergio Velderrain <[email protected]>
Date:   Mon Feb 17 11:32:48 2025 -0800

    Adding last details

commit 8c33476
Author: Sergio Velderrain <[email protected]>
Date:   Mon Feb 17 11:26:14 2025 -0800

    adding

commit aab5ec7
Author: Sergio Velderrain <[email protected]>
Date:   Mon Feb 17 10:47:06 2025 -0800

    commiting

commit 1a8e6d0
Author: Sergio Velderrain <[email protected]>
Date:   Mon Feb 17 09:10:52 2025 -0800

    a
@svelderrainruiz
Updating contributing.md
adbafef
@svelderrainruiz svelderrainruiz added the Type: Documentation Improvements or additions to documentation label Feb 17, 2025
@svelderrainruiz svelderrainruiz self-assigned this Feb 17, 2025
@svelderrainruiz svelderrainruiz linked an issue Feb 17, 2025 that may be closed by this pull request
Update contributing.md #121
Closed
crossrulz
crossrulz requested changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@crossrulz crossrulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 49:
Current: Did you found a workaround to any of the GitHub issues? we want to hear about it!
Correction: Did you find a workaround to any of the GitHub issues? We want to hear about it!
Changes: "found" to "find", Capitalize "We"

@svelderrainruiz
Update CONTRIBUTING.md
26bcbb5 
Adding changes from review
svelderrainruiz
svelderrainruiz commented Feb 18, 2025
View reviewed changes
Copy link
Collaborator Author

@svelderrainruiz svelderrainruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the change

@svelderrainruiz svelderrainruiz merged commit 14e9867 into develop Feb 18, 2025
2 checks passed
@svelderrainruiz svelderrainruiz deleted the 121-update-contributingmd branch February 18, 2025 01:47
svelderrainruiz added a commit that referenced this pull request Aug 7, 2025
@svelderrainruiz
docs: clarify build action usage (#122)
f383dd8 
## Summary
- mark `build` composite action as deprecated
- note that `ci-composite.yml` workflow uses `build-lvlibp` and
`build-vi-package` for builds

## Testing
- `python -m pytest`

------
https://chatgpt.com/codex/tasks/task_e_68943476c1ec8329bebe4bcdab154a34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crossrulz crossrulz crossrulz approved these changes

Assignees

@svelderrainruiz svelderrainruiz

Labels

Type: Documentation Improvements or additions to documentation

Projects

Icon Editor
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update contributing.md

2 participants

@svelderrainruiz @crossrulz