Skip to content

Add alert for unsupported browser version #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 5, 2025
Merged

Add alert for unsupported browser version #436

merged 4 commits into from
Nov 5, 2025

Conversation

@lamATnginx
Copy link
Collaborator

@lamATnginx lamATnginx commented Nov 4, 2025 •
edited
Loading

Proposed changes

Running on Safari 18, and setting the value for Safari in supportedNestedCSSVersion to 19:

Screenshot 2025-11-05 at 10 37 36 AM

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@lamATnginx lamATnginx self-assigned this Nov 4, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner November 4, 2025 22:53
@lamATnginx lamATnginx added the enhancement New feature or request label Nov 4, 2025
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-hugo-theme/436/

@lamATnginx lamATnginx changed the title Add alert for incompatible browser version Add alert for unsupported browser version Nov 5, 2025
travisamartin
travisamartin reviewed Nov 5, 2025
View reviewed changes
@lamATnginx lamATnginx force-pushed the chore/alert-browser-incompat branch from 37e0410 to 160ac46 Compare November 5, 2025 18:38
@lamATnginx lamATnginx force-pushed the chore/alert-browser-incompat branch from 160ac46 to 0a43b95 Compare November 5, 2025 18:39
@lamATnginx lamATnginx merged commit 826f3f3 into main Nov 5, 2025
7 checks passed
@lamATnginx lamATnginx deleted the chore/alert-browser-incompat branch November 5, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@travisamartin travisamartin travisamartin approved these changes

@nginx-jack nginx-jack nginx-jack approved these changes

Assignees

@lamATnginx lamATnginx

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lamATnginx @travisamartin @nginx-jack