-
Notifications
You must be signed in to change notification settings - Fork 102
POC: POC branch for external file implementation using cloud auth #1462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## external-file-mgmt-integration #1462 +/- ##
==================================================================
- Coverage 86.31% 85.88% -0.43%
==================================================================
Files 102 102
Lines 12603 12882 +279
==================================================================
+ Hits 10878 11064 +186
- Misses 1249 1333 +84
- Partials 476 485 +9
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
e50d100 to
2e981e0
Compare
|
This feature will be done by NGINXSaas team This PR was open as a part of POC to see how much the agent binary will increase if we add all the dependant packages directly to agen. |
Did a POC to see the imports required to add the file fetching and auth features directly in Agent code for 3 cloud providers
AWS,Azure,GCP
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)