-
Notifications
You must be signed in to change notification settings - Fork 103
[CI] add az-sync github action to handle secrets #1445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1445 +/- ##
=======================================
Coverage 85.15% 85.15%
=======================================
Files 102 102
Lines 12984 12984
=======================================
Hits 11057 11057
Misses 1440 1440
Partials 487 487 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| description: 'Target branch to run govulncheck against' | ||
| type: string | ||
| required: false | ||
| required: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering why the changes to the vulncheck were needed ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed for the Azure migration specifically, I just wanted to make them required and didn't want to open another PR.
Proposed changes
Adds a new custom Action to sync secrets from the Azure Keyvault. The action uses a filter pattern to pull secrets, and multiple patterns can be used by passing a comma-separated list. We call this function wherever we require secrets values to be in place, such as before calling the
Configure Go Proxystep in each job.In the job log output, you should see which secrets have been successfully synced for a pattern. These will be available in the
envfor any subsequent steps in that job:Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)