Reduce integration tests execution time #1171
Merged
+212
−217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
craigell
reviewed
Jul 16, 2025
aphralG
reviewed
Jul 17, 2025
|
I have hereby read the F5 CLA and agree to its terms |
dhurley
approved these changes
Jul 18, 2025
| "../../config/agent/nginx-config-with-grpc-client.conf") | ||
| defer teardownTest(t) | ||
|
|
||
| func (s *ConfigApplyTestSuite) TestGrpc_Test1_Reconnection() { |
There was a problem hiding this comment.
Suggested change
| func (s *ConfigApplyTestSuite) TestGrpc_Test1_Reconnection() { | |
| func (s *MPITestSuite) TestGrpc_Test1_Reconnection() { |
There was a problem hiding this comment.
Running the reconnection test in the MPI test suite causes the start up test to fail. I think its because of how the container is set up, the reconnection test works when expectNoErrorsInLogs is set to false, while the start up test works when it is set to true
aphralG
approved these changes
Jul 23, 2025
* add check for nginx pid file * add alpine default path /var/run/nginx/nginx.pid
* update go verion and golangci-lint * add paths for NAP upon instance discovery * use variable for NAP directory path * add paths when creating NAP instance * add nap paths by default, update agent config during upgrade * add nap by default * nap paths to default agent configuration * add back log message * only add config directory /etc/app_protect * update preinstall.sh * update default config * remove blank line --------- Co-authored-by: Aphral Griffin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR aims to use test suites to run multiple tests in a container in order to reduce overall execution time.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)