Add telemetry catalogs and weaver gen for metadata.yaml used by mdatagen #1043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
chore
|
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
|
I have hereby read the F5 CLA and agree to its terms |
|
recheck |
CodeMonkeyF5
force-pushed
the
telemetry-catalog
branch
from
b8c8694 to
fc4e45c
Compare
CodeMonkeyF5
force-pushed
the
telemetry-catalog
branch
12 times, most recently
from
853b54a to
9484d9b
Compare
fix: use latest mdatagen v0.124.0
CodeMonkeyF5
force-pushed
the
telemetry-catalog
branch
from
9484d9b to
c976640
Compare
aphralG
reviewed
Jul 22, 2025
| # correctly with the host user ID and host group ID. | ||
| # | ||
| # Error: OCI runtime error: crun: setgroups: Invalid argument | ||
| DOCKER_USER_IS_HOST_USER_ARG=--userns=keep-id -u $(DOCKER_USER) |
There was a problem hiding this comment.
Could the setting of the vars for the make target be moved into another Makefile like Makefile.weaver ? Like we do for containers and packaging
There was a problem hiding this comment.
Good suggestion, yes can separate this to its own Makefile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
These changes introduce a single source-of-truth for Agent V3 OTel metrics by creating a telemetry catalog that conforms to Weaver standards. Additionally, it automatically generates the
metadata.yamlfiles used by themdatagentool to produce all needed outputs for the collectors (nginxoss, nginxplus).Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)