-
Notifications
You must be signed in to change notification settings - Fork 96
Add telemetry catalogs and weaver gen for metadata.yaml used by mdatagen #1043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
I have hereby read the F5 CLA and agree to its terms |
recheck |
b8c8694
to
fc4e45c
Compare
853b54a
to
9484d9b
Compare
fix: use latest mdatagen v0.124.0
9484d9b
to
c976640
Compare
# correctly with the host user ID and host group ID. | ||
# | ||
# Error: OCI runtime error: crun: setgroups: Invalid argument | ||
DOCKER_USER_IS_HOST_USER_ARG=--userns=keep-id -u $(DOCKER_USER) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could the setting of the vars for the make target be moved into another Makefile like Makefile.weaver ? Like we do for containers and packaging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion, yes can separate this to its own Makefile.
Proposed changes
These changes introduce a single source-of-truth for Agent V3 OTel metrics by creating a telemetry catalog that conforms to Weaver standards. Additionally, it automatically generates the
metadata.yaml
files used by themdatagen
tool to produce all needed outputs for the collectors (nginxoss, nginxplus).Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentmake install-tools
and have attached any dependency changes to this pull requestREADME.md
)