feat: NFT.storage changes #2560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a bit ugly - there's no obvious way to include an actual link in the error messages - but we can iterate if this is too rough
point to the blogpost in all cases because of #11 from https://github.com/orgs/w3s-project/projects/1/views/1?pane=issue&itemId=57594940
|
lgtm, but worth fixing the failed check named 'website'. I think it might just be due to some lint rules (that IMO aren't that helpful here) https://github.com/nftstorage/nft.storage/actions/runs/8560717653/job/23460342853?pr=2560#step:5:121 |
gobengo
approved these changes
Apr 4, 2024
Deploying nft-storage with
|
| Latest commit: |
f6e3975
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://af72cdc5.nft-storage-1at.pages.dev |
| Branch Preview URL: | https://feat-nft-storage-changes.nft-storage-1at.pages.dev |
This was referenced Apr 4, 2024
travis
pushed a commit
that referenced
this pull request
Apr 5, 2024
🤖 I have created a release *beep* *boop* --- ## [2.10.0](website-v2.9.0...website-v2.10.0) (2024-04-04) ### Features * NFT.storage changes ([#2560](#2560)) ([1903214](1903214)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
travis
pushed a commit
that referenced
this pull request
Apr 5, 2024
🤖 I have created a release *beep* *boop* --- ## [4.7.0](api-v4.6.0...api-v4.7.0) (2024-04-04) ### Features * NFT.storage changes ([#2560](#2560)) ([1903214](1903214)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make all (most?) of the requested changes from https://github.com/orgs/w3s-project/projects/1/views/1?pane=issue&itemId=57594940
Note that once this PR is deployed, new user signups will be disabled - I did not put these behind a feature flag as there doesn't seem to be a strong need for one.
A few caveats:
We could make this prettier but it's nontrivial work, so I'm proposing we ship with this and iterate but would be open to iterating before we ship.