Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added nftests to gseagsea #7266

Merged
merged 14 commits into from
Jan 13, 2025
Merged

Added nftests to gseagsea #7266

merged 14 commits into from
Jan 13, 2025

Conversation

nschcolnicov
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@nschcolnicov nschcolnicov mentioned this pull request Dec 31, 2024
Closed
11 tasks
SPPearce
SPPearce reviewed Jan 8, 2025
View reviewed changes
modules/nf-core/gsea/gsea/main.nf Outdated Show resolved Hide resolved
modules/nf-core/gsea/gsea/main.nf Outdated Show resolved Hide resolved
modules/nf-core/gsea/gsea/main.nf Outdated Show resolved Hide resolved
SPPearce
SPPearce reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better to me.
Where are there unstable file names?

modules/nf-core/gsea/gsea/main.nf Outdated Show resolved Hide resolved
modules/nf-core/gsea/gsea/tests/main.nf.test Outdated Show resolved Hide resolved
@suzannejin suzannejin mentioned this pull request Jan 9, 2025
Open
4 tasks
@nschcolnicov nschcolnicov requested a review from a team as a code owner January 9, 2025 17:23
@nschcolnicov
Copy link
Contributor Author

@SPPearce All comments should be addressed now, let me know if there is anything else

SPPearce
SPPearce approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks for taking care of that, unset random seeds are an absolute nightmare for reproducibility.

@nschcolnicov nschcolnicov added this pull request to the merge queue Jan 13, 2025
Merged via the queue into master with commit 258399c Jan 13, 2025
27 checks passed
@nschcolnicov nschcolnicov deleted the add_nftests_gseagsea branch January 13, 2025 17:31
@nschcolnicov nschcolnicov mentioned this pull request Jan 17, 2025
Open
mazzalab pushed a commit to mazzalab/nf-core_modules that referenced this pull request Jan 18, 2025
@nschcolnicov @SPPearce @mazzalab
Added nftests to gseagsea (nf-core#7266)
e02aebd 
* Added nftests to gseagsea

* Update input files

* fix nftests

* Address PR comments

* Add seed setting parameter for stabilizing results

* Fix linting

* Add default random seed

* Update datasets paths

---------

Co-authored-by: Simon Pearce <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Jan 18, 2025
@mazzalab @Jorisvansteenbrugge
@SPPearce @renovate @vagkaratzas @prototaxites @nschcolnicov @GallVp
Bump wipertools to 1.1.4 (#7328)
e7f7c0f 
* Refactor fastq and report variable names for consistency across wipertools modules

* Refactor variable names for consistency in fastq and report processing modules

* Update test assertions to reflect changes in output variable names in fastqwiper module

* Update test assertions to match changes in report output structure in fastqwiper tests

* pypgx/runngspipeline (#6823)

* pypgx/runngspipeline

* update PR comments

---------

Co-authored-by: Jorisvansteenbrugge <[email protected]>
Co-authored-by: Simon Pearce <[email protected]>

* Update actions/upload-artifact digest to 65c4c4a (#7293)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fixed typo that produces "unknown recognition error type: groovyjarja… (#7295)

fixed typo that produces "unknown recognition error type: groovyjarjarantlr4.v4.runtime.LexerNoViableAltException" in pipelines

* Update Galah & add nf-tests (#7291)

* Update Galah & add nf-tests

* Fix linting

* Update main.nf

* Update inputs in meta.yml

* Fix missing snapshot output from broken test

* Added nftests to gseagsea (#7266)

* Added nftests to gseagsea

* Update input files

* fix nftests

* Address PR comments

* Add seed setting parameter for stabilizing results

* Fix linting

* Add default random seed

* Update datasets paths

---------

Co-authored-by: Simon Pearce <[email protected]>

* Bumped lima to 2.12.0 (#7294)

* Update container version to 1.1.4 and modify test names for clarity

* Remove obsolete test cases from fastqscatter and clean up pytest module configuration

* Update wipertools version to 1.1.4 in environment.yml files for fastqgather, fastqscatter, fastqwiper, and reportgather

* Update timestamps in fastqscatter test snapshots for consistency

---------

Co-authored-by: Joris van Steenbrugge <[email protected]>
Co-authored-by: Jorisvansteenbrugge <[email protected]>
Co-authored-by: Simon Pearce <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Evangelos Karatzas <[email protected]>
Co-authored-by: Jim Downie <[email protected]>
Co-authored-by: Nicolás Schcolnicov <[email protected]>
Co-authored-by: Usman Rashid <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SPPearce SPPearce SPPearce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nschcolnicov @SPPearce