-
Notifications
You must be signed in to change notification settings - Fork 10
Metacache #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metacache #140
Conversation
|
@jfy133 Closed the previous PR, this new PR has the dev branch as target. |
|
The failed GitHub test could be related to Fails with the following error message (nf-test 0.9.3, Nextflow 25.10.2, and openjdk version "24.0.2-internal" 2025-07-15): A similar error has been reported in the nf-test repo: Failing to run on JDK 24. |
|
Odd... so you can't run the test locally @alxndrdiaz ? Also I forogt to mention I put the development checklist on the website, https://nf-co.re/createtaxdb/2.0.0/docs/usage/usage/dev/ Maybe you can confirm you've been through it and checked everything before I dive in (I was hoping end of this week, but I just heard my kid is sick so might not be possible) |
No hurry. I will read the checklist in the meantime. The Nextlow tests work fine locally |
|
OK when I get back to this I'll try and replciat ehte erro |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I've updated the test snapshot (maybe try running
nf-test clean@alxndrdiaz to see if it fixes it - I've fixed a small bug in the output samplesheet
In the meantime, I will make the following changes (in addition to the comments below)
- Update CITATIONS.md
- Update the methods text
- Update the CHANGELOG
- Update the metro map
jfy133
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you look through to make sure you agree with my changes @alxndrdiaz , and if you do I think we are ready - thank you very much for picking this up!
|
@jfy133 LGTM, merging now |
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).