Skip to content

Fix single bin size - #21

Merged
nvnieuwk merged 3 commits into
devfrom
fix/single-bin-size
Feb 16, 2026
Merged

Fix single bin size#21
nvnieuwk merged 3 commits into
devfrom
fix/single-bin-size

Conversation

@nvnieuwk

Copy link
Copy Markdown
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@nvnieuwk
nvnieuwk requested a review from matthdsm February 16, 2026 13:59
Comment thread nextflow_schema.json
"properties": {
"bin_sizes": {
"type": "string",
"type": ["string", "integer"],

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be cleaner to just make this a List[int] ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but that sadly won't work with parameters

@nvnieuwk
nvnieuwk merged commit 33a424f into dev Feb 16, 2026
5 of 7 checks passed
@nvnieuwk
nvnieuwk deleted the fix/single-bin-size branch February 16, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants