feat(skills): configure upload size limit#1156
Open
evgyur wants to merge 1 commit into
Open
Conversation
Add a skills.max_upload_size_mb config option and GOCLAW_SKILLS_MAX_UPLOAD_SIZE_MB override while preserving the 20 MiB default upload cap. Wire the effective limit into skill ZIP uploads and cover config/env parsing plus handler enforcement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skills.max_upload_size_mbto the JSON/JSON5 config with the current 20 MiB behavior as the default.GOCLAW_SKILLS_MAX_UPLOAD_SIZE_MBas an environment override./v1/skills/upload.Test plan
gofmt -w internal/config/defaults.go internal/config/config.go internal/config/config_load.go internal/config/skills_config_test.go internal/http/skills.go internal/http/skills_upload.go internal/http/skills_upload_test.gogo test ./internal/config -run 'TestSkillsConfig|TestLoadSkillsMaxUploadSize' -count=1go test ./internal/http -run 'TestHandleUpload_UsesConfiguredMaxUploadSize|TestHandleUpload_AutoInstallsMissingDepsAndKeepsSkillActive' -count=1go test ./internal/config ./internal/http ./cmd -count=1git diff --checkCloses #1153