feat(channels): implement channels.toggle RPC method#1142
Open
zhihan wants to merge 1 commit into
Open
Conversation
Implement runtime channel enable/disable via WebSocket API.
Changes:
- Add StartChannel(), StopChannel(), IsChannelRunning() methods to Manager
- Implement handleToggle RPC handler in channels.go
- Support idempotent operations (already_running/already_stopped status)
- Thread-safe with existing mutex protection
- Health status tracking and structured logging
The channels.toggle method allows operators to enable or disable
messaging channels (telegram, discord, etc.) at runtime without
restarting the server. Useful for maintenance, debugging, and
incident response.
API:
Request: {method: channels.toggle, params: {channel: telegram, enabled: false}}
Response: {channel: telegram, enabled: false, status: ok}
Fixes the stub implementation that returned 'not implemented' error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the WebSocket RPC method that allows operators to enable/disable messaging channels at runtime without restarting the server.
Changes
Channel Manager ()
RPC Handler ()
API
Request:
{ "type": "req", "id": "1", "method": "channels.toggle", "params": { "channel": "telegram", "enabled": false } }Response:
{ "type": "res", "id": "1", "result": { "channel": "telegram", "enabled": false, "status": "ok" } }Use Cases
Testing
Notes
Fixes the stub implementation that previously returned 'channels.toggle not implemented' error.