Skip to content

fix(cron): invert stateless gate to match UI label #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codebit0 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −5
Open

fix(cron): invert stateless gate to match UI label #1139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions cmd/gateway_cron.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,14 @@ func makeCronJobHandler(sched *scheduler.Scheduler, msgBus *bus.MessageBus, cfg
defer cancelCron()
cronCtx = store.WithTenantID(cronCtx, job.TenantID)

// Reset session before each cron run to prevent tool errors from previous
// runs from polluting the context and blocking future executions (#294).
// Save() persists the empty session to DB so stale data won't reload after restart.
// Stateless jobs skip this — they intentionally carry no session history.
if !job.Stateless {
// Stateless jobs explicitly reset their session before each run — they
// carry no history between executions, matching the "Stateless" UI label
// and statelessHelp ("each run starts fresh without loading previous
// messages"). Stateful (non-stateless) jobs keep prior turns to enable
// multi-run dialog.
// Save() persists the empty session to DB so stale data won't reload
// after restart (#294).
if job.Stateless {
sessionMgr.Reset(cronCtx, sessionKey)
sessionMgr.Save(cronCtx, sessionKey)
}
Expand Down
Loading