Skip to content

Fix config for Trace level logging within the ConfigBuilder class #6040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kdesnos
Copy link
Contributor

@kdesnos kdesnos commented May 6, 2025

Fix issue #6039

Copy link

netlify bot commented May 6, 2025

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit e198ef2
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/681aad0c7736d8000895f1b2

@kdesnos
Copy link
Contributor Author

kdesnos commented May 6, 2025

The unit test error seems to occur in some code I didn't touch at all..

@kdesnos
Copy link
Contributor Author

kdesnos commented May 6, 2025

Note that an alternative solution would simply be to remove the call to isTraceEnable in CmdRun and let ConfigBuilder decide on its own.

Comment on lines +359 to +360

if( isTowerEnabled || isDataEnabled || LoggerFactory.getLogger(nextflow.config.ConfigBuilder).isTraceEnabled() )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just remove these conditions and resolve the config always

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never understood why we resolve it here anyway, when it is already resolved here

final builder = new ConfigBuilder()
.setOptions(launcher.options)
.setCmdRun(this)
.setBaseDir(scriptFile.parent)
final config = builder .build()

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this it's done to render it as a string using

.setShowClosures(true)
.setStripSecrets(true)

maybe it can be done reusing the config object already build, but never looked into that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants