-
Notifications
You must be signed in to change notification settings - Fork 689
Include remote path in FileHolder #5911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rcannood
wants to merge
9
commits into
nextflow-io:master
Choose a base branch
from
rcannood:add-origPath-to-FileHolder
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+16
−7
Open
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b3d4fe0
add origPath as an argument to FileHolder
rcannood 0a2ae72
Alternative solution
rcannood b1083c3
Revert "Alternative solution"
rcannood 1793efc
Expose source path
rcannood 7ac07c9
Implement CacheFunnel for FileHolder
bentsherman c1c96fd
Merge branch 'master' into add-origPath-to-FileHolder
rcannood e62f851
Merge branch 'master' into add-origPath-to-FileHolder
bentsherman 3e1df62
Merge branch 'master' into pr/rcannood/5911
bentsherman 8d2add3
Resolve symlink in two-arg constructor
bentsherman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
modules/nf-commons/src/main/nextflow/file/RemoteFileHolder.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
/* | ||
* Copyright 2013-2024, Seqera Labs | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package nextflow.file | ||
|
||
import java.nio.file.Path | ||
|
||
import groovy.transform.CompileStatic | ||
import groovy.transform.EqualsAndHashCode | ||
import groovy.transform.ToString | ||
import groovy.util.logging.Slf4j | ||
|
||
import nextflow.file.FileHolder | ||
|
||
/** | ||
* Implements a special {@code Path} used to stage files in the work area | ||
*/ | ||
@Slf4j | ||
@ToString(includePackage = false, includeNames = true) | ||
@EqualsAndHashCode | ||
@CompileStatic | ||
class RemoteFileHolder extends FileHolder { | ||
|
||
final Path origPath | ||
|
||
RemoteFileHolder( Path inputFile, Path origPath ) { | ||
super(inputFile) | ||
this.origPath = origPath | ||
} | ||
|
||
RemoteFileHolder( def origin, Path path, Path origPath ) { | ||
super(origin, path) | ||
this.origPath = origPath | ||
} | ||
|
||
protected RemoteFileHolder( def source, Path store, def stageName, Path origPath ) { | ||
super(source, store, stageName) | ||
this.origPath = origPath | ||
} | ||
|
||
Path getOrigPath() { origPath } | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.