feat: Verify file integrity in chunks #607
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Git'Fellow <[email protected]>
solracsf
force-pushed
the
verifyIntChunks
branch
from
f07dc04 to
6a7ee2d
Compare
|
|
||
| $signature = base64_decode($response['signature']); | ||
|
|
||
| $validSignature = openssl_verify($data, $signature, $certificate, OPENSSL_ALGO_SHA512); |
There was a problem hiding this comment.
Doesn't this chunk the initial read but still populate $data with the entire archive content leading to the same state?
In short, the chunking would only be helpful if openssl_verify itself did it.
There was a problem hiding this comment.
Yeah you are right. Using file_get_contents() or a loop that concatenates chunks into a string, ultimately results in the entire file being held in memory at once...
I'm closing this because i've thinked it wrongly, I'll try to provide a better PR later. Thanks 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #598