Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/279 pagination for tables ui #972

Merged

Conversation

grnd-alt
Copy link
Member

@grnd-alt grnd-alt commented Apr 10, 2024

Design

image

Performance

Loading Time for 3k Rows with pagination

2024-04-12.19-21-40.mp4

3k Rows Without pagination

2024-04-12.19-27-09.mp4

@grnd-alt grnd-alt self-assigned this Apr 10, 2024
@grnd-alt grnd-alt linked an issue Apr 10, 2024 that may be closed by this pull request
2 tasks
@grnd-alt grnd-alt force-pushed the enhancement/279-virtual-scrolling-and-lazy-loading-for-table-ui branch from 6cb26b2 to e835475 Compare April 10, 2024 14:20
@enjeck
Copy link
Contributor

enjeck commented Apr 15, 2024

I realize this is still a draft, but just wondering if this PR adds pagination or virtual scrolling? There seems to be a mismatch between the title and the commit message 😅

@grnd-alt
Copy link
Member Author

I realize this is still a draft, but just wondering if this PR adds pagination or virtual scrolling? There seems to be a mismatch between the title and the commit message 😅

Yeah it's because the initial issue planned to implement v-scrolling but that's harder to do on html tables than expected hence we decided to look into pagination

@grnd-alt grnd-alt changed the title Enhancement/279 virtual scrolling and lazy loading for table UI Enhancement/279 pagination for tables ui Apr 15, 2024
@juliusknorr juliusknorr marked this pull request as ready for review April 23, 2024 18:49
@juliusknorr juliusknorr marked this pull request as draft April 23, 2024 18:51
@juliusknorr juliusknorr added this to the v0.8.0 milestone Apr 24, 2024
@grnd-alt grnd-alt force-pushed the enhancement/279-virtual-scrolling-and-lazy-loading-for-table-ui branch 5 times, most recently from 25a0b71 to ce4a23b Compare April 26, 2024 07:17
@grnd-alt grnd-alt marked this pull request as ready for review April 26, 2024 10:22
@jancborchardt jancborchardt self-requested a review April 26, 2024 10:30
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! :)

An improvement on the style would be to use the default color-main-background and instead use a drop shadow like the action menus have.
This would correspond better with it being a floating element above others, and also look a bit more modern than a greyish element.

@grnd-alt grnd-alt force-pushed the enhancement/279-virtual-scrolling-and-lazy-loading-for-table-ui branch from ce4a23b to d91da73 Compare April 26, 2024 11:59
@grnd-alt
Copy link
Member Author

@jancborchardt Updated With New Screenshot

@enjeck enjeck self-requested a review April 29, 2024 07:48
@juliusknorr juliusknorr added enhancement New feature or request 2. developing Work in progress labels Apr 29, 2024
@jancborchardt
Copy link
Member

@jancborchardt Updated With New Screenshot

It doesn’t look like it has the drop shadow, but that looks fine to me, as long as the background is opaque color-main-background – so the element is still readable when there is a long table below it. :)

@grnd-alt grnd-alt force-pushed the enhancement/279-virtual-scrolling-and-lazy-loading-for-table-ui branch 2 times, most recently from cb49883 to def38b5 Compare May 3, 2024 12:16
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments, otherwise very nice 🚀

@grnd-alt grnd-alt force-pushed the enhancement/279-virtual-scrolling-and-lazy-loading-for-table-ui branch from def38b5 to 808b21e Compare May 6, 2024 07:12
@grnd-alt grnd-alt requested a review from juliusknorr May 6, 2024 12:19
@grnd-alt grnd-alt dismissed jancborchardt’s stale review May 13, 2024 08:21

dismissing so you don't have to approve. Drop shadow is now used.

@grnd-alt grnd-alt merged commit 3145800 into main May 13, 2024
45 checks passed
@grnd-alt grnd-alt deleted the enhancement/279-virtual-scrolling-and-lazy-loading-for-table-ui branch May 13, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Virtual scrolling and lazy loading for table UI
4 participants