-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/279 pagination for tables ui #972
Enhancement/279 pagination for tables ui #972
Conversation
6cb26b2
to
e835475
Compare
I realize this is still a draft, but just wondering if this PR adds pagination or virtual scrolling? There seems to be a mismatch between the title and the commit message 😅 |
Yeah it's because the initial issue planned to implement v-scrolling but that's harder to do on html tables than expected hence we decided to look into pagination |
25a0b71
to
ce4a23b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice! :)
An improvement on the style would be to use the default color-main-background and instead use a drop shadow like the action menus have.
This would correspond better with it being a floating element above others, and also look a bit more modern than a greyish element.
ce4a23b
to
d91da73
Compare
@jancborchardt Updated With New Screenshot |
It doesn’t look like it has the drop shadow, but that looks fine to me, as long as the background is opaque color-main-background – so the element is still readable when there is a long table below it. :) |
cb49883
to
def38b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor comments, otherwise very nice 🚀
Signed-off-by: grnd-alt <[email protected]>
def38b5
to
808b21e
Compare
dismissing so you don't have to approve. Drop shadow is now used.
Design
Performance
Loading Time for 3k Rows with pagination
2024-04-12.19-21-40.mp4
3k Rows Without pagination
2024-04-12.19-27-09.mp4