Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(nextcloud): refactor test file structure #2339

Merged
merged 6 commits into from
Aug 5, 2024

Conversation

Leptopoda
Copy link
Member

I hope the conventional commit types are right :)

@Leptopoda Leptopoda requested a review from provokateurin August 1, 2024 16:32
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not sure if we should have webdav in lib/src/api and not in lib/src since it is very different from all the other apis. Not really related to this PR though as this was changed earlier already.

@Leptopoda
Copy link
Member Author

I'm not sure if we should have webdav in lib/src/api

I can see your point. Let's see, where #1123 and #718 go to. Feel free to change it.

@Leptopoda Leptopoda force-pushed the refactor/nextcloud/split_unit_tests branch from 52376e6 to a970274 Compare August 5, 2024 08:43
@Leptopoda Leptopoda requested a review from provokateurin August 5, 2024 08:45
@provokateurin
Copy link
Member

The changes to the news test should also change the paths of the fixtures 🤔

@Leptopoda
Copy link
Member Author

We should add a CI that validates that.
I think a simple check that the repo didn't have any changes after the test would be enough?

@provokateurin
Copy link
Member

I think just failing when a new fixture had to be created is good enough. Since we do not use retries anymore the failure should be propagated to the command.

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 47.82609% with 24 lines in your changes missing coverage. Please review.

Project coverage is 25.23%. Comparing base (5c41a87) to head (108ae00).
Report is 4 commits behind head on main.

Files Patch % Lines
.../src/api/webdav/utils/xml_date_time_converter.dart 36.84% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2339      +/-   ##
==========================================
+ Coverage   25.15%   25.23%   +0.08%     
==========================================
  Files         332      333       +1     
  Lines      140021   140021              
==========================================
+ Hits        35217    35336     +119     
+ Misses     104804   104685     -119     
Flag Coverage Δ *Carryforward flag
cookie_store 100.00% <ø> (ø) Carriedforward from 5c41a87
dynamite 31.08% <ø> (ø) Carriedforward from 5c41a87
dynamite_end_to_end_test 60.96% <ø> (ø) Carriedforward from 5c41a87
dynamite_runtime 85.40% <ø> (ø) Carriedforward from 5c41a87
neon_dashboard 96.20% <ø> (ø)
neon_framework 45.84% <ø> (ø)
neon_http_client 93.28% <ø> (ø)
neon_notifications 100.00% <ø> (ø)
neon_talk 99.46% <ø> (ø)
nextcloud 22.15% <47.82%> (+0.09%) ⬆️
sort_box 90.90% <ø> (ø) Carriedforward from 5c41a87

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...b/src/api/notifications/notifications_helpers.dart 81.81% <100.00%> (+69.31%) ⬆️
...src/api/notifications/notifications_helpers.g.dart 92.37% <ø> (+92.37%) ⬆️
...s/nextcloud/lib/src/api/spreed/spreed_helpers.dart 100.00% <100.00%> (+19.04%) ⬆️
...ges/nextcloud/lib/src/api/webdav/models/props.dart 62.50% <ø> (ø)
...rc/api/webdav/utils/webdav_response_converter.dart 100.00% <100.00%> (ø)
packages/nextcloud/lib/src/utils/date_time.dart 100.00% <ø> (+57.14%) ⬆️
packages/nextcloud/lib/webdav.dart 100.00% <ø> (ø)
.../src/api/webdav/utils/xml_date_time_converter.dart 36.84% <36.84%> (ø)

@Leptopoda Leptopoda force-pushed the refactor/nextcloud/split_unit_tests branch from a970274 to 1b26252 Compare August 5, 2024 09:07
@Leptopoda Leptopoda force-pushed the refactor/nextcloud/split_unit_tests branch from 1b26252 to 108ae00 Compare August 5, 2024 09:08
@Leptopoda Leptopoda merged commit 1bd0179 into main Aug 5, 2024
10 checks passed
@Leptopoda Leptopoda deleted the refactor/nextcloud/split_unit_tests branch August 5, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants