-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(nextcloud): refactor test file structure #2339
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'm not sure if we should have webdav in lib/src/api and not in lib/src since it is very different from all the other apis. Not really related to this PR though as this was changed earlier already.
packages/nextcloud/test/api/notifications/notifications_helpers_test.dart
Show resolved
Hide resolved
52376e6
to
a970274
Compare
The changes to the news test should also change the paths of the fixtures 🤔 |
We should add a CI that validates that. |
I think just failing when a new fixture had to be created is good enough. Since we do not use retries anymore the failure should be propagated to the command. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2339 +/- ##
==========================================
+ Coverage 25.15% 25.23% +0.08%
==========================================
Files 332 333 +1
Lines 140021 140021
==========================================
+ Hits 35217 35336 +119
+ Misses 104804 104685 -119
*This pull request uses carry forward flags. Click here to find out more.
|
a970274
to
1b26252
Compare
Signed-off-by: Nikolas Rimikis <[email protected]>
Signed-off-by: Nikolas Rimikis <[email protected]>
Signed-off-by: Nikolas Rimikis <[email protected]>
Signed-off-by: Nikolas Rimikis <[email protected]>
Signed-off-by: Nikolas Rimikis <[email protected]>
Signed-off-by: Nikolas Rimikis <[email protected]>
1b26252
to
108ae00
Compare
I hope the conventional commit types are right :)