fix: empty folder appearance

[alperozturk96]

• Tests written, or not not needed

Issue

Since MetadataWorker updates the eTag newly added files not determined by client any more, thus empty folder may appear.

Screen.Recording.2025-10-20.at.15.07.15.mov

Demo

Changes

Only updates e-Tag after successful RefreshFolderOperation otherwise resets e-Tag.
Only stores new e-Tag after saving child files to storage.

How to test?

1. Create sub folder in root directory
2. Add one file from web
3. Check metadata worker
4. Create another sub folder from web
5. Add big files to the first sub-folder
6. Open app and navigate to the newly created subfolder
7. Navigate back to the root (so that we can trigger worker to cancel previously unfinished job)
8. Navigate to the newly created subfolder again
9. Navigate back to the root
10. Check new files existence from DB or navigate to the first subfolder

[alperozturk96]

We can safely reset the e-Tag if the RefreshFolderOperation fails. Since the operation is only executed when the e-Tag differs, setting it back to null in the event of a failure is acceptable and will not trigger any unnecessary additional operations.

[alperozturk96]

Only update mLocalFolder e-Tag and file-length after saving all children files to the directory.

Later on in run fileDataStorageManager.saveFile(mLocalFolder); will be called after fetchAndSyncRemoteFolder

[alperozturk96]

/backport to stable-3.34

pr is updated

[github-actions]

test-Unit test failed, but no output was generated. Maybe a preliminary stage failed.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	45	42
Errors	11	11

SpotBugs

SpotBugs increased!

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15819.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.