Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix avatar title not shown when component used without menu #6297

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Koc
Copy link

@Koc Koc commented Dec 7, 2024

☑️ Resolves

Right now title not visible if NcAvatar used without menu. This PR fixes that by moving title to parent span element.

🖼️ Screenshots

🔍 Preview after fix

image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Koc Koc force-pushed the bugfix/fix-avatar-title branch from 13b58b5 to 0b20e22 Compare December 7, 2024 22:16
@GretaD GretaD requested review from Pytal, ShGKme and susnux December 9, 2024 13:36
@ChristophWurst
Copy link
Contributor

Thank you for your contribution, @Koc!

Engineers with accessibility expertise are probably best to review the change. We've therefore requested their review.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.30%. Comparing base (2ed3522) to head (50c8ded).
Report is 61 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6297   +/-   ##
=======================================
  Coverage   42.30%   42.30%           
=======================================
  Files         154      154           
  Lines        3988     3988           
  Branches     1023      999   -24     
=======================================
  Hits         1687     1687           
- Misses       2190     2193    +3     
+ Partials      111      108    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Koc Koc force-pushed the bugfix/fix-avatar-title branch from 0b20e22 to 50c8ded Compare December 13, 2024 17:46
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fixes the issue, but it is not accessible. We should think about an alternative solution (I have no idea at the moment).

@Koc
Copy link
Author

Koc commented Jan 2, 2025

@Pytal @ShGKme let's merge then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants