chore: simplify modernization follow-up#37
Merged
Conversation
Code review pass on #36. - check script: drop unquoted bash character class api/[endpoint].js (fragile under shopt -s failglob / zsh nomatch) and merge the two invocations into one find. Also picks up scripts/fetch-fonts.js, which the previous form silently skipped, and any future siblings under api/. - ci.yml: add Node 24 to the test matrix. engines says ">=22 <25" but CI was only running 22 — self-hosters on 24 (Active LTS) had no signal. Matrix changes the required-check name to "test (22)" / "test (24)"; branch protection is updated alongside. - dependabot.yml: drop the inline comment on actions-minor — restated what update-types already says. - SECURITY.md: collapse the 4-row timeline to the two stages a single-maintainer project can actually commit to (acknowledgement, 90-day disclosure).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code review pass on #36.
(fragile under shopt -s failglob / zsh nomatch) and merge the two
invocations into one find. Also picks up scripts/fetch-fonts.js,
which the previous form silently skipped, and any future siblings
under api/.
CI was only running 22 — self-hosters on 24 (Active LTS) had no
signal. Matrix changes the required-check name to "test (22)" /
"test (24)"; branch protection is updated alongside.
what update-types already says.
single-maintainer project can actually commit to (acknowledgement,
90-day disclosure).