feat(composer): v3.4.1 — inline edit on stats / pin / languages (closes #29)#30
Merged
Conversation
#29) Extends the inline-edit pattern from hero (v3.4) to three more cards. ProfileKit-side: data-cas-target hooks added to the title text in cards that go through renderCard (stats, languages — via a new optional titleTarget arg), and to the repo name + description groups in pin.js. Visual output unchanged. Playground-side: introduces INLINE_EDIT_CARDS set; cards in the set render as inline <svg> (with click handlers) instead of <img>. Hero still gets the bg-popover; everything else routes data-cas-target clicks to focusSlotInput in the right pane. Snake intentionally skipped — no obvious editable text. Out of v3.4.1: color-slot type (v3.4.2), keyboard / a11y (v3.5).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds data-cas-target hooks to stats, languages (via new titleTarget arg in renderCard), and pin (repo + description). Playground generalizes to INLINE_EDIT_CARDS set. Click-to-jump-to-slot-input pattern. See #29.