Kinesis instrumentation #2974
Open
Kinesis instrumentation #2974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimpleCov Report
|
lib/new_relic/agent/instrumentation/aws_sdk_kinesis/instrumentation.rb
Outdated
Show resolved
Hide resolved
Co-authored-by: Kayla Reopelle <[email protected]>
kaylareopelle
previously approved these changes
Dec 18, 2024
tannalynn
reviewed
Dec 20, 2024
| def get_arn(params) | ||
| return params[:stream_arn] if params&.dig(:stream_arn) | ||
|
|
||
| NewRelic::Agent::Aws.create_arn(KINESIS.downcase, "stream/#{params[:stream_name]}", config&.region, nr_account_id) if params&.dig(:stream_name) |
There was a problem hiding this comment.
how come the if is checking for params&.dig(:stream_name), but method is using just params[:stream_name]?
There was a problem hiding this comment.
Ah I was using the params&.dig in part for safe navigation, but to your point this doesnt really make sense to dig and then assume the stream_name is top level. An oversight. Updating!
tannalynn
reviewed
Dec 20, 2024
| end | ||
|
|
||
| def get_segment_name(method_name, params) | ||
| return "#{KINESIS}/#{method_name}/#{params[:stream_name]}" if params&.dig(:stream_name) |
There was a problem hiding this comment.
Same question on the dig VS direct hash on stream_name here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for aws-sdk-kinesis.