Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(agent): improve PHP version compatibility check #485

Merged
merged 1 commit into from
Jul 14, 2022
Merged

refactor(agent): improve PHP version compatibility check #485

merged 1 commit into from
Jul 14, 2022

Conversation

hahuja2
Copy link
Contributor

@hahuja2 hahuja2 commented Jul 11, 2022 •
edited by lavarou
Loading

Address #56 in one place.

@CLAassistant
Copy link

CLAassistant commented Jul 11, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@nr-opensource-bot
Copy link

Can one of the admins verify this patch?

@hahuja2
Copy link
Contributor Author

hahuja2 commented Jul 11, 2022

ok jenkins

@ZNeumann
Copy link
Contributor

ok jenkins

mfulb
mfulb approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@mfulb mfulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on first PR!

@lavarou lavarou changed the title Chore(agent): replace php api number define with preferred style refactor(agent): improve PHP version compatibility check Jul 13, 2022
lavarou
lavarou approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@lavarou lavarou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on first PR!

zsistla
zsistla approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@zsistla zsistla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@hahuja2 hahuja2 merged commit 5b30adf into newrelic:dev Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsistla zsistla zsistla approved these changes

@mfulb mfulb mfulb approved these changes

@lavarou lavarou lavarou approved these changes

@bduranleau-nr bduranleau-nr bduranleau-nr approved these changes

@ZNeumann ZNeumann Awaiting requested review from ZNeumann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@hahuja2 @CLAassistant @nr-opensource-bot @ZNeumann @zsistla @mfulb @lavarou @bduranleau-nr