-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Laravel Lumen support #38
Conversation
ok jenkins |
Thanks for doing this work! One question regarding exception handling. Should something similar be done for lumen? Lumen says exceptions are handled by |
This PR seems to have recent changes from |
ok jenkins |
Purpose
Adds framework detection for Lumen, and upon detection of it, will automatically name transactions by the route name, or in the absence of a usable route name, the controller name (this behavior mirrors our implementation of symfony route naming).
Logs
Reviewing
It might be helpful to compare this with the Symfony 4 instrumentation, as it is very similar. Lumen uses an Illuminate Request class that extends the Symfony Request class, but routing information is obtained in a slightly different way.