fix: Console logging is inconsistent between Agent and Profiler #2955
+61
−52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2939.
Modifies and optimizes logging behavior in the agent as follows:
NEW_RELIC_LOG_ENABLED
NEW_RELIC_LOG_CONSOLE
newrelic.config
<log enabled="true" />
<log enabled="true" console="true" />
<log enabled="false" />
Notes:
SilentLogger
which is an empty implementation of theSerilog.ILogger
interface. We also set the log level tooff
, which will short-circuit nearly all calls to the public methods inLogger
.newrelic.config
remains unchangednewrelic.config
via<log enabled="true" auditLog="true" />
Profiler logging already follows this behavior so no changes were required.
Does not include tests; behavior was manually verified.