Skip to content
This repository has been archived by the owner on Jun 30, 2020. It is now read-only.

Use API version 1 instead of beta. Update docs #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mshamota-nr
Copy link
Contributor

@mshamota-nr mshamota-nr commented Apr 20, 2020

Version for Deamonset API is migrated according to
https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/
Without it, I wasn't able to run it locally.
I followed instructions in DEVELOPER.md and found that they need to be updated accordingly:)

@mshamota-nr mshamota-nr requested a review from bmcfeely April 20, 2020 13:15
@CLAassistant
Copy link

CLAassistant commented Apr 20, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@bmcfeely bmcfeely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! What will this mean for customers on older versions of k8s? Does someone in BCN know what our strategy should be for this? I think I saw that this issue exists somewhere else, but that someone didn't want to change yet. I don't know. :)

@Voziv
Copy link
Contributor

Voziv commented May 5, 2020

Great! What will this mean for customers on older versions of k8s? Does someone in BCN know what our strategy should be for this? I think I saw that this issue exists somewhere else, but that someone didn't want to change yet. I don't know. :)

Ideally the chart should be versioned and stored in a chart repository. People who need the older api can still reference the older chart.

Would love to see this merged in soon as the chart doesn't currently work with our clusters

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants