Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add finch instrumentation #469

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Add finch instrumentation #469

merged 3 commits into from
Jan 13, 2025

Conversation

binaryseed
Copy link
Collaborator

Adds automatic Finch instrumentation based on :telemetry events.

Note:

  • If your app already manually instruments Finch requests with @trace, you'll see a warning to remove that instrumentation or to disable automatic Finch instrumentation

@binaryseed binaryseed requested a review from tpitale December 28, 2024 00:19
@binaryseed binaryseed mentioned this pull request Dec 28, 2024
19 tasks
@binaryseed binaryseed force-pushed the vince/instrument-finch branch from 19170b0 to ce499ec Compare January 9, 2025 21:23
@binaryseed binaryseed force-pushed the vince/instrument-finch branch from ce499ec to 7b60d4a Compare January 9, 2025 21:32
@binaryseed
Copy link
Collaborator Author

Rebased & ready for review

tpitale
tpitale previously approved these changes Jan 13, 2025
@tpitale tpitale merged commit c3bef0b into master Jan 13, 2025
11 checks passed
@tpitale tpitale deleted the vince/instrument-finch branch January 13, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants