Conditional compilation to address warnings #456
Conversation
lib/new_relic/logger.ex
Outdated
| @@ -81,7 +81,13 @@ defmodule NewRelic.Logger do | |||
|
|
|||
| defp elixir_logger(:debug, message), do: Logger.debug(message) | |||
| defp elixir_logger(:info, message), do: Logger.info(message) | |||
| defp elixir_logger(:warn, message), do: Logger.warn(message) | |||
|
|
|||
| if Version.match?(System.version(), ">= 1.11.0") do | |||
There was a problem hiding this comment.
Since we have that ConditionalCompile, should this also use that?
There was a problem hiding this comment.
Also: do we support elixir before 1.11? The earliest we test against is 1.11.
There was a problem hiding this comment.
Thanks missed this spot. Updated all of them to use ConditionalCompile
There was a problem hiding this comment.
I don't know what we "support"
#454 changes the test matrix to the last 4 versions, and Elixir itself seems to support the last 5 versions with security patches.
https://hexdocs.pm/elixir/1.18.0-rc.0/compatibility-and-deprecations.html
We could adopt that, which would put us at 1.14 and above
There was a problem hiding this comment.
Regardless, 1.10 and 1.11 are very old, so I've removed the conditionals that matched those version
|
This one is ready for review |
Address some warnings that arise across different Elixir versions
+0.0Logger.warnAlso modify
ConditionalCompileto not need a macro