Skip to content

Conversation

@circlecube
Copy link
Member

Summary

Adds reusable codecoverage workflow (was missing) and Playwright E2E; removes Cypress where applicable.

Changes

  • Codecoverage: Added codecoverage-main.yml.
  • Playwright: Added brand-plugin-test-playwright.yml (where applicable).
  • Cypress: Removed brand-plugin-test.yml (where applicable).

Benefits

  • Single source of truth for coverage and E2E.

@circlecube circlecube self-assigned this Jan 28, 2026
@circlecube circlecube requested a review from a team January 28, 2026 23:24
Comment on lines +18 to +26
runs-on: ubuntu-latest
outputs:
repository-name: ${{ steps.repo-name.outputs.name }}
steps:
- name: Extract repository name
id: repo-name
run: echo "name=$(echo ${{ github.repository }} | cut -d'/' -f2)" >> $GITHUB_OUTPUT

codecoverage:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI about 4 hours ago

In general, the fix is to explicitly define a restrictive permissions block for all jobs that use the default GITHUB_TOKEN, rather than relying on repository/organization defaults. For this workflow, the minimal safe choice is to add permissions: contents: read to the get-repo-name job, since it only needs to read repository metadata and does not appear to write anything. The codecoverage job already has an explicit permissions block, so no change is required there.

Concretely, in .github/workflows/codecoverage-main.yml, under the get-repo-name job (lines 17–24), insert a permissions: section after runs-on: ubuntu-latest giving it contents: read. This constrains the GITHUB_TOKEN used in that job to read‑only repository contents, aligning with the principle of least privilege without changing the job’s behavior. No imports or additional definitions are needed, as this is purely a YAML configuration change.

Suggested changeset 1
.github/workflows/codecoverage-main.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/codecoverage-main.yml b/.github/workflows/codecoverage-main.yml
--- a/.github/workflows/codecoverage-main.yml
+++ b/.github/workflows/codecoverage-main.yml
@@ -16,6 +16,8 @@
 jobs:
   get-repo-name:
     runs-on: ubuntu-latest
+    permissions:
+      contents: read
     outputs:
       repository-name: ${{ steps.repo-name.outputs.name }}
     steps:
EOF
@@ -16,6 +16,8 @@
jobs:
get-repo-name:
runs-on: ubuntu-latest
permissions:
contents: read
outputs:
repository-name: ${{ steps.repo-name.outputs.name }}
steps:
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants