feat: add extra env/volumes/volumeMounts to implement the ability to … #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@venkateshjayagopal any feedback on this one? |
| projected: | ||
| defaultMode: 420 | ||
| sources: | ||
| - configMap: |
There was a problem hiding this comment.
I was really looking forward to this functionality. Nice PR! Should we set it to a secret rather than a configmap since the ca bundle can be potentially sensitive information ?
| projected: | ||
| defaultMode: 420 | ||
| sources: | ||
| - configMap: |
There was a problem hiding this comment.
same note as above swapping from configMap to secret
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change resolves #193 by adding extraEnv, extraVolume and extraVolumeMounts.
Signed-off by: Marco Varagnolo [email protected]