Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip RXD tests on ARM #3177

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Skip RXD tests on ARM #3177

merged 1 commit into from
Nov 6, 2024

Conversation

JCGoran
Copy link
Collaborator

@JCGoran JCGoran commented Nov 6, 2024

Workaround for failures on ARM caused by #3143.
For MaOS it works in the CI (see this run), while for Linux I verified it locally.

Copy link

sonarqubecloud bot commented Nov 6, 2024

@JCGoran JCGoran requested a review from nrnhines November 6, 2024 10:27
@JCGoran JCGoran marked this pull request as ready for review November 6, 2024 10:27
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.06%. Comparing base (68b193d) to head (b930c9c).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3177   +/-   ##
=======================================
  Coverage   67.06%   67.06%           
=======================================
  Files         571      571           
  Lines      111318   111321    +3     
=======================================
+ Hits        74656    74659    +3     
  Misses      36662    36662           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nrnhines nrnhines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this does not fall through the cracks, please associate with an issue that can be closed when a PR comes forth that resolves the problem and turns the test back on.

Copy link

✔️ b930c9c -> Azure artifacts URL

@JCGoran
Copy link
Collaborator Author

JCGoran commented Nov 6, 2024

Done, opened #3179 for this.

@alkino alkino merged commit 5cdc7fa into master Nov 6, 2024
36 checks passed
@alkino alkino deleted the jelic/skip_tests branch November 6, 2024 16:05
JCGoran added a commit that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants