-
Notifications
You must be signed in to change notification settings - Fork 14
added note Pre/Post Glioma segmentation with links + formated links #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
evamariie
commented
May 29, 2025
- added Note with links (from BrainLesion/BraTS ) regarding Algorithms adult glioma segmentation Pre + Post Treatment
- formated two Warning notes - using blockquote
…ockquote - added Note with links regarding adult glioma segmentation Algothms Pre + Post Treatment - formated two Warning notes - using blockquote
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the README to add a new informational note with links for Adult Glioma Segmentation and reformats existing warning messages into a blockquote style.
- Added a [!NOTE] block with links for Pre-Treatment and Post-Treatment segmentation algorithms.
- Reformatted deprecation warnings for both the BraTS Preprocessor and the GUI into blockquotes.
… format of the document
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
README.md
Outdated
| > [!NOTE] | ||
| > Algorithms are now available for Adult Glioma Segmentation <br> | ||
| Pre-Treatment: https://github.com/BrainLesion/BraTS?tab=readme-ov-file#adult-glioma-segmentation-pre-treatment <br> | ||
| and Post-Treatment: https://github.com/BrainLesion/BraTS?tab=readme-ov-file#adult-glioma-segmentation-post-treatment). <br> |
Copilot
AI
Sep 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an extra closing parenthesis on line 80 after the URL that should be removed.
| and Post-Treatment: https://github.com/BrainLesion/BraTS?tab=readme-ov-file#adult-glioma-segmentation-post-treatment). <br> | |
| and Post-Treatment: https://github.com/BrainLesion/BraTS?tab=readme-ov-file#adult-glioma-segmentation-post-treatment. <br> |
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
README.md
Outdated
|
|
||
| ## Usage | ||
| BrainLes features [Jupyter notebook tutorials](https://github.com/BrainLesion/tutorials/tree/main/BraTS-Toolkit) for glioma segmentation with BraTS Toolkit. | ||
| BrainLes features (Jupyter notebook tutorials: https://github.com/BrainLesion/tutorials/tree/main/BraTS-Toolkit) for glioma segmentation with BraTS Toolkit. |
Copilot
AI
Sep 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parentheses around the link description create awkward formatting. Consider using proper markdown link syntax: [Jupyter notebook tutorials](https://github.com/BrainLesion/tutorials/tree/main/BraTS-Toolkit) for better readability and consistency with markdown conventions.
| BrainLes features (Jupyter notebook tutorials: https://github.com/BrainLesion/tutorials/tree/main/BraTS-Toolkit) for glioma segmentation with BraTS Toolkit. | |
| BrainLes features [Jupyter notebook tutorials](https://github.com/BrainLesion/tutorials/tree/main/BraTS-Toolkit) for glioma segmentation with BraTS Toolkit. |
README.md
Outdated
| For segmentation, your files should be `preprocessed`, meaning they should be co-registered and skullstripped in SRI-24 space. | ||
| You can preprocess your files using [BrainLes preprocessing](https://github.com/BrainLesion/preprocessing) (recommended) or the deprecated preprocessor of BraTS Toolkit (see below). | ||
|
|
||
| You can preprocess your files using BrainLes preprocessing: https://github.com/BrainLesion/preprocessing (recommended) or the deprecated preprocessor of BraTS Toolkit (see below). |
Copilot
AI
Sep 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link formatting is inconsistent with markdown conventions. Consider using proper markdown link syntax: [BrainLes preprocessing](https://github.com/BrainLesion/preprocessing) for better readability and consistency.
| You can preprocess your files using BrainLes preprocessing: https://github.com/BrainLesion/preprocessing (recommended) or the deprecated preprocessor of BraTS Toolkit (see below). | |
| You can preprocess your files using [BrainLes preprocessing](https://github.com/BrainLesion/preprocessing) (recommended) or the deprecated preprocessor of BraTS Toolkit (see below). |
README.md
Outdated
|
|
||
| > WARNING: BraTS Preprocessor is deprecated. It still works, but we recommended using [BrainLes preprocessing](https://github.com/BrainLesion/preprocessing) instead, which offers much more flexibility. | ||
| > [!WARNING] | ||
| > BraTS Preprocessor is deprecated. It still works, but we recommended using BrainLes preprocessing: https://github.com/BrainLesion/preprocessing instead, which offers much more flexibility. |
Copilot
AI
Sep 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link formatting is inconsistent with markdown conventions. Consider using proper markdown link syntax: [BrainLes preprocessing](https://github.com/BrainLesion/preprocessing) for better readability and consistency.
| > BraTS Preprocessor is deprecated. It still works, but we recommended using BrainLes preprocessing: https://github.com/BrainLesion/preprocessing instead, which offers much more flexibility. | |
| > BraTS Preprocessor is deprecated. It still works, but we recommended using BrainLes preprocessing: [BrainLes preprocessing](https://github.com/BrainLesion/preprocessing) instead, which offers much more flexibility. |
Improve formatting in README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| > WARNING: BraTS Preprocessor is deprecated. It still works, but we recommended using [BrainLes preprocessing](https://github.com/BrainLesion/preprocessing) instead, which offers much more flexibility. | ||
| > [!WARNING] | ||
| > BraTS Preprocessor is deprecated. It still works, but we recommend using [BrainLes preprocessing](https://github.com/BrainLesion/preprocessing) instead, which offers much more flexibility. |
Copilot
AI
Sep 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word 'recommend' should be 'recommended' to maintain consistency with the original text and proper grammar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@evamariie Copilot is right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.