Skip to content

Conversation

@evamariie
Copy link
Contributor

  • added Note with links (from BrainLesion/BraTS ) regarding Algorithms adult glioma segmentation Pre + Post Treatment
  • formated two Warning notes - using blockquote

evamariie added 2 commits May 29, 2025 16:26
…ockquote

- added Note with links regarding adult glioma segmentation Algothms Pre + Post Treatment 
- formated two Warning notes - using blockquote
@neuronflow neuronflow requested a review from Copilot June 2, 2025 08:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the README to add a new informational note with links for Adult Glioma Segmentation and reformats existing warning messages into a blockquote style.

  • Added a [!NOTE] block with links for Pre-Treatment and Post-Treatment segmentation algorithms.
  • Reformatted deprecation warnings for both the BraTS Preprocessor and the GUI into blockquotes.

@evamariie evamariie marked this pull request as draft June 4, 2025 14:47
@evamariie evamariie marked this pull request as ready for review September 22, 2025 14:24
@evamariie evamariie changed the title added note Pre/Post Glioma segmentation with links + formated with bl… formated links, to have consistent fomrat of links in the document Sep 22, 2025
@evamariie evamariie changed the title formated links, to have consistent fomrat of links in the document formated links, to have consistent format of links in the document Sep 22, 2025
@evamariie evamariie changed the title formated links, to have consistent format of links in the document added GlioMODA link into the note Sep 22, 2025
@evamariie evamariie changed the title added GlioMODA link into the note added note Pre/Post Glioma segmentation with links + formated links Sep 22, 2025
@evamariie evamariie requested a review from Copilot September 22, 2025 14:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

README.md Outdated
> [!NOTE]
> Algorithms are now available for Adult Glioma Segmentation <br>
Pre-Treatment: https://github.com/BrainLesion/BraTS?tab=readme-ov-file#adult-glioma-segmentation-pre-treatment <br>
and Post-Treatment: https://github.com/BrainLesion/BraTS?tab=readme-ov-file#adult-glioma-segmentation-post-treatment). <br>
Copy link

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra closing parenthesis on line 80 after the URL that should be removed.

Suggested change
and Post-Treatment: https://github.com/BrainLesion/BraTS?tab=readme-ov-file#adult-glioma-segmentation-post-treatment). <br>
and Post-Treatment: https://github.com/BrainLesion/BraTS?tab=readme-ov-file#adult-glioma-segmentation-post-treatment. <br>

Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <[email protected]>
@evamariie evamariie requested a review from Copilot September 22, 2025 14:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <[email protected]>
@evamariie evamariie requested a review from Copilot September 22, 2025 14:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

README.md Outdated

## Usage
BrainLes features [Jupyter notebook tutorials](https://github.com/BrainLesion/tutorials/tree/main/BraTS-Toolkit) for glioma segmentation with BraTS Toolkit.
BrainLes features (Jupyter notebook tutorials: https://github.com/BrainLesion/tutorials/tree/main/BraTS-Toolkit) for glioma segmentation with BraTS Toolkit.
Copy link

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parentheses around the link description create awkward formatting. Consider using proper markdown link syntax: [Jupyter notebook tutorials](https://github.com/BrainLesion/tutorials/tree/main/BraTS-Toolkit) for better readability and consistency with markdown conventions.

Suggested change
BrainLes features (Jupyter notebook tutorials: https://github.com/BrainLesion/tutorials/tree/main/BraTS-Toolkit) for glioma segmentation with BraTS Toolkit.
BrainLes features [Jupyter notebook tutorials](https://github.com/BrainLesion/tutorials/tree/main/BraTS-Toolkit) for glioma segmentation with BraTS Toolkit.

Copilot uses AI. Check for mistakes.
README.md Outdated
For segmentation, your files should be `preprocessed`, meaning they should be co-registered and skullstripped in SRI-24 space.
You can preprocess your files using [BrainLes preprocessing](https://github.com/BrainLesion/preprocessing) (recommended) or the deprecated preprocessor of BraTS Toolkit (see below).

You can preprocess your files using BrainLes preprocessing: https://github.com/BrainLesion/preprocessing (recommended) or the deprecated preprocessor of BraTS Toolkit (see below).
Copy link

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link formatting is inconsistent with markdown conventions. Consider using proper markdown link syntax: [BrainLes preprocessing](https://github.com/BrainLesion/preprocessing) for better readability and consistency.

Suggested change
You can preprocess your files using BrainLes preprocessing: https://github.com/BrainLesion/preprocessing (recommended) or the deprecated preprocessor of BraTS Toolkit (see below).
You can preprocess your files using [BrainLes preprocessing](https://github.com/BrainLesion/preprocessing) (recommended) or the deprecated preprocessor of BraTS Toolkit (see below).

Copilot uses AI. Check for mistakes.
README.md Outdated

> WARNING: BraTS Preprocessor is deprecated. It still works, but we recommended using [BrainLes preprocessing](https://github.com/BrainLesion/preprocessing) instead, which offers much more flexibility.
> [!WARNING]
> BraTS Preprocessor is deprecated. It still works, but we recommended using BrainLes preprocessing: https://github.com/BrainLesion/preprocessing instead, which offers much more flexibility.
Copy link

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link formatting is inconsistent with markdown conventions. Consider using proper markdown link syntax: [BrainLes preprocessing](https://github.com/BrainLesion/preprocessing) for better readability and consistency.

Suggested change
> BraTS Preprocessor is deprecated. It still works, but we recommended using BrainLes preprocessing: https://github.com/BrainLesion/preprocessing instead, which offers much more flexibility.
> BraTS Preprocessor is deprecated. It still works, but we recommended using BrainLes preprocessing: [BrainLes preprocessing](https://github.com/BrainLesion/preprocessing) instead, which offers much more flexibility.

Copilot uses AI. Check for mistakes.
@evamariie evamariie marked this pull request as draft September 22, 2025 14:37
Improve formatting in README.md
@evamariie evamariie requested a review from Copilot September 22, 2025 14:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@evamariie evamariie requested a review from Copilot September 22, 2025 14:50
@evamariie evamariie marked this pull request as ready for review September 22, 2025 14:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <[email protected]>
@evamariie evamariie requested a review from Copilot September 22, 2025 14:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@neuronflow neuronflow requested a review from Copilot September 22, 2025 15:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.


> WARNING: BraTS Preprocessor is deprecated. It still works, but we recommended using [BrainLes preprocessing](https://github.com/BrainLesion/preprocessing) instead, which offers much more flexibility.
> [!WARNING]
> BraTS Preprocessor is deprecated. It still works, but we recommend using [BrainLes preprocessing](https://github.com/BrainLesion/preprocessing) instead, which offers much more flexibility.
Copy link

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word 'recommend' should be 'recommended' to maintain consistency with the original text and proper grammar.

Copilot uses AI. Check for mistakes.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evamariie Copilot is right

@neuronflow neuronflow requested a review from Copilot September 23, 2025 05:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@neuronflow neuronflow self-requested a review September 23, 2025 05:19
@neuronflow neuronflow merged commit 86e7fa8 into neuronflow:main Sep 23, 2025
3 checks passed
@evamariie evamariie deleted the patch-1 branch September 26, 2025 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants