Skip to content

Commit

Permalink
Fix linter issues (#283)
Browse files Browse the repository at this point in the history
Signed-off-by: Artem Glazychev <[email protected]>
  • Loading branch information
glazychev-art authored Jun 22, 2021
1 parent ef75b5a commit 88ca6da
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 5 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,12 @@ jobs:
steps:
- name: Check out code into the Go module directory
uses: actions/checkout@v2
with:
fetch-depth: 0
- name: golangci-lint
uses: golangci/golangci-lint-action@v2
with:
version: v1.37.1
only-new-issues: true
excludeFmtErrorf:
name: exclude fmt.Errorf
runs-on: ubuntu-latest
Expand Down
6 changes: 4 additions & 2 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ linters-settings:
suggest-new: true
dupl:
threshold: 150
funlen:
lines: 70
goconst:
min-len: 2
min-occurrences: 2
Expand Down Expand Up @@ -168,7 +170,7 @@ issues:
- path: pkg/networkservice/mechanisms/kernel/kernelvethpair/common.go
linters:
- funlen
text: "Function 'create'"
- gocyclo
- path: pkg/networkservice/mechanisms/kernel/kerneltap/common.go
linters:
- funlen
Expand All @@ -184,4 +186,4 @@ issues:
- path: pkg/networkservice/mechanisms/vxlan/common.go
linters:
- funlen
text: "Function 'create'"
text: "Function 'addDel'"
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) 2020 Cisco and/or its affiliates.
// Copyright (c) 2020-2021 Cisco and/or its affiliates.
//
// SPDX-License-Identifier: Apache-2.0
//
Expand Down
2 changes: 1 addition & 1 deletion pkg/networkservice/mechanisms/kernel/kerneltap/client.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) 2020 Cisco and/or its affiliates.
// Copyright (c) 2020-2021 Cisco and/or its affiliates.
//
// SPDX-License-Identifier: Apache-2.0
//
Expand Down

0 comments on commit 88ca6da

Please sign in to comment.