Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenTelemetry Collector #7053

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

anastasia-malysheva
Copy link
Contributor

@anastasia-malysheva anastasia-malysheva commented Aug 10, 2022

Add fixes for OPA update to the latest version

Signed-off-by: anastasia.malysheva [email protected]

@anastasia-malysheva anastasia-malysheva changed the title Add fixes for OPA update to the latest version Update OpenTelemetry Collector Aug 10, 2022
… into fixes_for_opa_update

� Conflicts:
�	examples/features/jaeger/README.md
@@ -2,5 +2,7 @@
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

namespace: nsm-system
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually no, I'll remove

Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not sure that we need folder

examples/features/jaeger/nsm-system.

Because this example is using by users that already setup NSM.

Other things are looking fine.

@NikitaSkrynnik Could you also have a look?

Copy link
Collaborator

@NikitaSkrynnik NikitaSkrynnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anastasia-malysheva
Copy link
Contributor Author

@denis-tingaikin , I think local nsm configs needed for this example because we have to be sure that tracing is enabled for forwarder and manager, even though it is enabled by default now. Plus this setup is not installing nsm as in other examples in the folder, but it applies it as any other resources.

Signed-off-by: anastasia.malysheva <[email protected]>
@denis-tingaikin
Copy link
Member

@anastasia-malysheva Could you please resolve conflict?

… into fixes_for_opa_update

� Conflicts:
�	examples/features/jaeger/README.md
@anastasia-malysheva
Copy link
Contributor Author

@denis-tingaikin conflicts resolved

… into fixes_for_opa_update

� Conflicts:
�	examples/features/jaeger/README.md
… into fixes_for_opa_update

� Conflicts:
�	examples/features/jaeger/README.md
�	examples/observability/jaeger-and-prometheus/README.md
�	examples/observability/jaeger-and-prometheus/nsm-system/kustomization.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants