-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OpenTelemetry Collector #7053
base: main
Are you sure you want to change the base?
Update OpenTelemetry Collector #7053
Conversation
Signed-off-by: anastasia.malysheva <[email protected]>
… into fixes_for_opa_update � Conflicts: � examples/features/jaeger/README.md
@@ -2,5 +2,7 @@ | |||
apiVersion: kustomize.config.k8s.io/v1beta1 | |||
kind: Kustomization | |||
|
|||
namespace: nsm-system |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually no, I'll remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im not sure that we need folder
examples/features/jaeger/nsm-system
.
Because this example is using by users that already setup NSM.
Other things are looking fine.
@NikitaSkrynnik Could you also have a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@denis-tingaikin , I think local nsm configs needed for this example because we have to be sure that tracing is enabled for forwarder and manager, even though it is enabled by default now. Plus this setup is not installing nsm as in other examples in the folder, but it applies it as any other resources. |
Signed-off-by: anastasia.malysheva <[email protected]>
@anastasia-malysheva Could you please resolve conflict? |
… into fixes_for_opa_update � Conflicts: � examples/features/jaeger/README.md
@denis-tingaikin conflicts resolved |
… into fixes_for_opa_update � Conflicts: � examples/features/jaeger/README.md
… into fixes_for_opa_update � Conflicts: � examples/features/jaeger/README.md � examples/observability/jaeger-and-prometheus/README.md � examples/observability/jaeger-and-prometheus/nsm-system/kustomization.yaml
Add fixes for OPA update to the latest version
Signed-off-by: anastasia.malysheva [email protected]