Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[integration-k8s-kind#325] Add Calico patches for VPP Forwarder #3305

Conversation

Bolodya1997
Copy link

@Bolodya1997 Bolodya1997 commented Nov 1, 2021

Description

Adds patches and if [[ -n $CALICO ]] if [[ "${CALICO}" == "on" ]] checks for running NSM tests with Calico VPP.

Issue link

networkservicemesh/integration-k8s-kind#325

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

Comment on lines 24 to 28
if [[ -n ${CALICO} ]]; then # calico
kubectl apply -k https://github.com/networkservicemesh/deployments-k8s/examples/multiforwarder/calico?ref=d3257910fdcb2038340b892023d746205369a599
else
kubectl apply -k https://github.com/networkservicemesh/deployments-k8s/examples/multiforwarder?ref=d3257910fdcb2038340b892023d746205369a599
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edwarnicke Do you mind if we'll enable calico via ENV?

@Bolodya1997 Bolodya1997 force-pushed the integration-k8s-kind#325/calico-forwarder branch from 167a741 to 277308e Compare November 2, 2021 05:30
@Bolodya1997 Bolodya1997 marked this pull request as draft November 3, 2021 11:43
@Bolodya1997 Bolodya1997 force-pushed the integration-k8s-kind#325/calico-forwarder branch from 277308e to d9a3a9f Compare November 3, 2021 12:26
@Bolodya1997 Bolodya1997 marked this pull request as ready for review November 3, 2021 13:53
@Mixaster995 Mixaster995 self-assigned this Nov 29, 2021
@denis-tingaikin
Copy link
Member

This is completed in networkservicemesh/sdk-vpp#470

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants